]> www.infradead.org Git - users/hch/block.git/commitdiff
block: remove superfluous calls to blkcg_bio_issue_init
authorChristoph Hellwig <hch@lst.de>
Thu, 31 Mar 2022 09:21:27 +0000 (11:21 +0200)
committerChristoph Hellwig <hch@lst.de>
Sat, 23 Apr 2022 16:24:34 +0000 (18:24 +0200)
blkcg_bio_issue_init is called in submit_bio.  There is no need to have
extra calls that just get overriden in __bio_clone and the two places
that copy and pasted from it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
block/bio.c
block/blk-crypto-fallback.c
block/bounce.c

index 4259125e16ab24075d902f989f424f8b046c9bee..3cffc01e6377fc575fd0d82e134ba577b8b9107e 100644 (file)
@@ -739,7 +739,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp)
        bio->bi_iter = bio_src->bi_iter;
 
        bio_clone_blkg_association(bio, bio_src);
-       blkcg_bio_issue_init(bio);
 
        if (bio_crypt_clone(bio, bio_src, gfp) < 0)
                return -ENOMEM;
index 7c854584b52b506fece323d6275948a10f9a7849..5ddf33f999dfe1a9edcb2421964ef46f334a83c2 100644 (file)
@@ -177,7 +177,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src)
                bio->bi_io_vec[bio->bi_vcnt++] = bv;
 
        bio_clone_blkg_association(bio, bio_src);
-       blkcg_bio_issue_init(bio);
 
        return bio;
 }
index 467be46d0e65620c08067579ff4fd30f1ce666a6..8f7b6fe3b4db5f621e5efce566ab3e9697b44fd9 100644 (file)
@@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src)
                goto err_put;
 
        bio_clone_blkg_association(bio, bio_src);
-       blkcg_bio_issue_init(bio);
 
        return bio;