]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: codecs: lpass-rx-macro: Fix using NULL pointer in probe() dev_err
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 28 Jun 2024 09:58:30 +0000 (11:58 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 1 Jul 2024 19:07:29 +0000 (20:07 +0100)
The 'rx->dev' is assigned closer to the end of the probe() function, so
the dev_err() must not use it - it is still NULL at this point.  Instead
there is already a local 'dev' variable.

Fixes: dbacef05898d ("ASoC: codec: lpass-rx-macro: prepare driver to accomdate new codec versions")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patch.msgid.link/20240628095831.207942-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/lpass-rx-macro.c

index 9c4f0763675d61821333ab520f642a740402cf8e..d47c49c90de364ddb2ead1056ab8ed4c6873ffbd 100644 (file)
@@ -3842,7 +3842,7 @@ static int rx_macro_probe(struct platform_device *pdev)
                                rx_2_5_defaults, sizeof(rx_2_5_defaults));
                break;
        default:
-               dev_err(rx->dev, "Unsupported Codec version (%d)\n", rx->codec_version);
+               dev_err(dev, "Unsupported Codec version (%d)\n", rx->codec_version);
                ret = -EINVAL;
                goto err;
        }