leds: turris-omnia: Inform about missing LED gamma correction feature in the MCU...

If the LED gamma correction feature is missing in the MCU firmware,
inform about this in the MCU firmware probe function instead of LED
driver probe function, so that all the feature checks are in one place.

Signed-off-by: Marek Behún <kabel@kernel.org>
Link: https://lore.kernel.org/r/20241111100355.6978-10-kabel@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>

diff --git a/drivers/leds/leds-turris-omnia.c b/drivers/leds/leds-turris-omnia.c
index 4f7b529781ce7cfb90f786a7a8adccec93990ac7..cfbcbdd7921b0aaf215c3a1802c697faf47c4848 100644 (file)
--- a/drivers/leds/leds-turris-omnia.c
+++ b/drivers/leds/leds-turris-omnia.c
@@ -507,12 +507,6 @@ static int omnia_leds_probe(struct i2c_client *client)
        }
 
        leds->has_gamma_correction = ret & OMNIA_FEAT_LED_GAMMA_CORRECTION;
-       if (!leds->has_gamma_correction) {
-               dev_info(dev,
-                        "Your board's MCU firmware does not support the LED gamma correction feature.\n");
-               dev_info(dev,
-                        "Consider upgrading MCU firmware with the omnia-mcutool utility.\n");
-       }
 
        if (ret & OMNIA_FEAT_BRIGHTNESS_INT) {
                ret = omnia_request_brightness_irq(leds);

diff --git a/drivers/platform/cznic/turris-omnia-mcu-base.c b/drivers/platform/cznic/turris-omnia-mcu-base.c
index 3bb4a3cfdb29c61bcd47c14e70fae9e202d7d23c..770e680b96f95d91f54f55dc3738565d05d19fcd 100644 (file)
--- a/drivers/platform/cznic/turris-omnia-mcu-base.c
+++ b/drivers/platform/cznic/turris-omnia-mcu-base.c
@@ -259,6 +259,7 @@ static int omnia_mcu_read_features(struct omnia_mcu *mcu)
                _DEF_FEAT(POWEROFF_WAKEUP,      "poweroff and wakeup"),
                _DEF_FEAT(TRNG,                 "true random number generator"),
                _DEF_FEAT(BRIGHTNESS_INT,       "LED panel brightness change interrupt"),
+               _DEF_FEAT(LED_GAMMA_CORRECTION, "LED gamma correction"),
 #undef _DEF_FEAT
        };
        struct i2c_client *client = mcu->client;