tcmu: return on first Opt parse failure

We only were returing failure if the last opt to be parsed failed.
This has a return failure when we first detect a failure.

Signed-off-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Orabug: 25395066
(cherry picked from commit 2579325ca0acc598fdf41ba12b2871d3467f28df)
Signed-off-by: Kyle Fortin <kyle.fortin@oracle.com>
Reviewed-by: Shan Hai <shan.hai@oracle.com>

diff --git a/drivers/target/target_core_user.c b/drivers/target/target_core_user.c
index 1f6f86667d57d41596213d161494456ee3a62621..26b8fc38300ff1de81c029b1924f06549f8e909c 100644 (file)
--- a/drivers/target/target_core_user.c
+++ b/drivers/target/target_core_user.c
@@ -1111,6 +1111,9 @@ static ssize_t tcmu_set_configfs_dev_params(struct se_device *dev,
                default:
                        break;
                }
+
+               if (ret)
+                       break;
        }
 
        kfree(orig);