]> www.infradead.org Git - users/hch/misc.git/commitdiff
kbuild: userprogs: avoid duplication of flags inherited from kernel
authorThomas Weißschuh <thomas.weissschuh@linutronix.de>
Wed, 13 Aug 2025 05:43:40 +0000 (07:43 +0200)
committerNathan Chancellor <nathan@kernel.org>
Mon, 18 Aug 2025 17:42:58 +0000 (10:42 -0700)
The duplication makes maintenance harder. Changes need to be done in two
places and the lines will grow overly long.

Use an intermediary variable instead.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: Nicolas Schier <n.schier@avm.de>
Acked-by: Masahiro Yamada <masahiroy@kernel.org>
Link: https://lore.kernel.org/r/20250813-kbuild-userprogs-bits-v1-1-2d9f7f411083@linutronix.de
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Makefile

index 6630a66659c6d1ca7e72448b04d16c3fdd1fbe24..3e8544b11520158af39608b4ac15ade7117922b8 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -1135,8 +1135,9 @@ LDFLAGS_vmlinux   += --emit-relocs --discard-none
 endif
 
 # Align the bit size of userspace programs with the kernel
-KBUILD_USERCFLAGS  += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS))
-KBUILD_USERLDFLAGS += $(filter -m32 -m64 --target=%, $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS))
+USERFLAGS_FROM_KERNEL := -m32 -m64 --target=%
+KBUILD_USERCFLAGS  += $(filter $(USERFLAGS_FROM_KERNEL), $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS))
+KBUILD_USERLDFLAGS += $(filter $(USERFLAGS_FROM_KERNEL), $(KBUILD_CPPFLAGS) $(KBUILD_CFLAGS))
 
 # userspace programs are linked via the compiler, use the correct linker
 ifdef CONFIG_CC_IS_CLANG