mm/damon/sysfs: rename damon_sysfs_set_targets() to ...add_targets()

The function was for updating DAMON structs that may or may not be
partially populated.  Hence it was not for only adding items, but also
removing unnecessary items and updating items in-place.  A previous commit
has changed the function to assume the structs are not partially
populated, and do only adding items.  Make the function name better
explain the behavior.

Link: https://lkml.kernel.org/r/20240618181809.82078-7-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/damon/sysfs-test.h b/mm/damon/sysfs-test.h
index 43a15156a7c36970a8ad3e79dac84e1267641011..1c9b596057a7ccbed809b6085902112e638f3504 100644 (file)
--- a/mm/damon/sysfs-test.h
+++ b/mm/damon/sysfs-test.h
@@ -38,7 +38,7 @@ static int __damon_sysfs_test_get_any_pid(int min, int max)
        return -1;
 }
 
-static void damon_sysfs_test_set_targets(struct kunit *test)
+static void damon_sysfs_test_add_targets(struct kunit *test)
 {
        struct damon_sysfs_targets *sysfs_targets;
        struct damon_sysfs_target *sysfs_target;
@@ -56,12 +56,12 @@ static void damon_sysfs_test_set_targets(struct kunit *test)
 
        ctx = damon_new_ctx();
 
-       damon_sysfs_set_targets(ctx, sysfs_targets);
+       damon_sysfs_add_targets(ctx, sysfs_targets);
        KUNIT_EXPECT_EQ(test, 1u, nr_damon_targets(ctx));
 
        sysfs_target->pid = __damon_sysfs_test_get_any_pid(
                        sysfs_target->pid + 1, 200);
-       damon_sysfs_set_targets(ctx, sysfs_targets);
+       damon_sysfs_add_targets(ctx, sysfs_targets);
        KUNIT_EXPECT_EQ(test, 2u, nr_damon_targets(ctx));
 
        damon_destroy_ctx(ctx);
@@ -71,7 +71,7 @@ static void damon_sysfs_test_set_targets(struct kunit *test)
 }
 
 static struct kunit_case damon_sysfs_test_cases[] = {
-       KUNIT_CASE(damon_sysfs_test_set_targets),
+       KUNIT_CASE(damon_sysfs_test_add_targets),
        {},
 };
 

diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index c729222797b8d1171c7d003ae95e9d2466485e02..f83ea6a166c62fea86b3e17be723a0f3b8f6b1eb 100644 (file)
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -1162,7 +1162,7 @@ destroy_targets_out:
        return err;
 }
 
-static int damon_sysfs_set_targets(struct damon_ctx *ctx,
+static int damon_sysfs_add_targets(struct damon_ctx *ctx,
                struct damon_sysfs_targets *sysfs_targets)
 {
        int i, err;
@@ -1283,7 +1283,7 @@ static int damon_sysfs_apply_inputs(struct damon_ctx *ctx,
        err = damon_sysfs_set_attrs(ctx, sys_ctx->attrs);
        if (err)
                return err;
-       err = damon_sysfs_set_targets(ctx, sys_ctx->targets);
+       err = damon_sysfs_add_targets(ctx, sys_ctx->targets);
        if (err)
                return err;
        return damon_sysfs_set_schemes(ctx, sys_ctx->schemes);