]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
wireguard: device: omit unnecessary memset of netdev private data
authorTobias Klauser <tklauser@distanz.ch>
Sun, 17 Nov 2024 21:20:27 +0000 (22:20 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Nov 2024 03:32:27 +0000 (19:32 -0800)
The memory for netdev_priv is allocated using kvzalloc in
alloc_netdev_mqs before rtnl_link_ops->setup is called so there is no
need to zero it again in wg_setup.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
Link: https://patch.msgid.link/20241117212030.629159-2-Jason@zx2c4.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wireguard/device.c

index 45e9b908dbfb05633f1496130cc005653130fd1a..a2ba71fbbed46954bd176c621af066b1b82878c5 100644 (file)
@@ -302,7 +302,6 @@ static void wg_setup(struct net_device *dev)
        /* We need to keep the dst around in case of icmp replies. */
        netif_keep_dst(dev);
 
-       memset(wg, 0, sizeof(*wg));
        wg->dev = dev;
 }