]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
perf test: Fix leak in "Synthesize attr update" test
authorIan Rogers <irogers@google.com>
Wed, 5 Mar 2025 19:19:31 +0000 (11:19 -0800)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 6 Mar 2025 23:59:41 +0000 (15:59 -0800)
The own_cpus map variable may be non-NULL and hold a reference, in
particular on hybrid machines. Do a put before overwriting the
variable to avoid a memory leak.

Signed-off-by: Ian Rogers <irogers@google.com>
Reviewed-by: James Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250305191931.604764-1-irogers@google.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/tests/event_update.c

index d6b4ce3ef4ee989fe459e718d01abec6e515bcd5..9301fde1136633fafdcf3ecb70636e331586c441 100644 (file)
@@ -109,6 +109,7 @@ static int test__event_update(struct test_suite *test __maybe_unused, int subtes
        TEST_ASSERT_VAL("failed to synthesize attr update name",
                        !perf_event__synthesize_event_update_name(&tmp.tool, evsel, process_event_name));
 
+       perf_cpu_map__put(evsel->core.own_cpus);
        evsel->core.own_cpus = perf_cpu_map__new("1,2,3");
 
        TEST_ASSERT_VAL("failed to synthesize attr update cpus",