]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
RDS: IB: change rds_ib_active_bonding_excl_ips to only RFC3927 space
authorTodd Vierling <todd.vierling@oracle.com>
Tue, 28 Jun 2016 19:56:13 +0000 (15:56 -0400)
committerChuck Anderson <chuck.anderson@oracle.com>
Fri, 8 Jul 2016 05:44:03 +0000 (22:44 -0700)
Currently rds_ib_active_bonding_excl_ips excludes both
169.254.0.0/16 and 172.10.0.0/16 address ranges from use with RDS
bonding. This parameter was meant to default to the range used by
link-local addresses (169.254.0.0/16, RFC3927) as those do not play
nicely with InfiniBand.

"172.10/16" was probably a mistaken typing of "172.16/12", which is
one of the private use -- but not link-local -- ranges defined by
RFC1918. 172.10.0.0/16 is in active use on the global Internet
(part of the block 172.0.0.0/12 as of this writing); it doesn't
belong here.

Change the parameter default to only "169.254/16" per the original
change's intent.

Orabug; 23712042

Signed-off-by: Todd Vierling <todd.vierling@oracle.com>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
net/rds/ib.c

index 63a2ac02b01b8ff388ef83f843ad8b8e1e886c51..dbc711214f925bf2080a81e1d80c9c2de0a61ecb 100644 (file)
@@ -61,7 +61,7 @@ unsigned int rds_ib_active_bonding_trigger_delay_min_msecs; /* = 0; */
 unsigned int rds_ib_rnr_retry_count = RDS_IB_DEFAULT_RNR_RETRY_COUNT;
 static char *rds_ib_active_bonding_failover_groups = NULL;
 unsigned int rds_ib_active_bonding_arps = RDS_IB_DEFAULT_NUM_ARPS;
-static char *rds_ib_active_bonding_excl_ips = "169.254/16,172.10/16";
+static char *rds_ib_active_bonding_excl_ips = "169.254/16";
 
 module_param(rds_ib_fmr_1m_pool_size, int, 0444);
 MODULE_PARM_DESC(rds_ib_fmr_1m_pool_size, " Max number of 1m fmr per HCA");