]> www.infradead.org Git - users/dwmw2/openconnect.git/commitdiff
Remove NULL checks before deinit GnuTLS objects.
authorTom Carroll <incentivedesign@gmail.com>
Wed, 12 May 2021 07:46:08 +0000 (00:46 -0700)
committerDavid Woodhouse <dwmw2@infradead.org>
Mon, 17 May 2021 10:29:41 +0000 (11:29 +0100)
GnuTLS handles these just like a traditional free() function and copes
if they're NULL. We don't have to check.

Signed-off-by: Tom Carroll <incentivedesign@gmail.com>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
gnutls.c

index 3b400e07a1e1ebd2874465ca29ff946f50996469..97aeaeb65fd088fad4562edabb26c31401f24f61 100644 (file)
--- a/gnutls.c
+++ b/gnutls.c
@@ -937,10 +937,8 @@ struct gtls_cert_info {
 
 static void free_gtls_cert_info(struct gtls_cert_info *gci)
 {
-       if (gci->crl)
-               gnutls_x509_crl_deinit(gci->crl);
-       if (gci->pkey)
-               gnutls_privkey_deinit(gci->pkey);
+       gnutls_x509_crl_deinit(gci->crl);
+       gnutls_privkey_deinit(gci->pkey);
        if (gci->certs) {
                for (int i = 0; i < gci->nr_certs; i++)
                        gnutls_x509_crt_deinit(gci->certs[i]);