mt76: mt7615: fix potential memory leak in mcu message handler

[ Upstream commit 9248c08c3fc4ef816c82aa49d01123f4746d349f ]

Fix potential memory leak in mcu message handler on error condition.

Fixes: 0e6a29e477f3 ("mt76: mt7615: add support to read temperature from mcu")
Acked-by: Lorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
index 842cd81704db6f7888743ee10c145f244b806e38..b6867d93c0e348b9e332b6c745eb31fc113159c8 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7615/mcu.c
@@ -119,8 +119,10 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
        struct mt7615_mcu_rxd *rxd = (struct mt7615_mcu_rxd *)skb->data;
        int ret = 0;
 
-       if (seq != rxd->seq)
-               return -EAGAIN;
+       if (seq != rxd->seq) {
+               ret = -EAGAIN;
+               goto out;
+       }
 
        switch (cmd) {
        case -MCU_CMD_PATCH_SEM_CONTROL:
@@ -134,6 +136,7 @@ mt7615_mcu_parse_response(struct mt7615_dev *dev, int cmd,
        default:
                break;
        }
+out:
        dev_kfree_skb(skb);
 
        return ret;