genirq/chip: Rework handle_fasteoi_ack_irq()

Use the new helpers to decide whether the interrupt should be handled and
switch the descriptor locking to guard().

Fixup the kernel doc comment while at it.

No functional change.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065421.105015800@linutronix.de

diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
index 6c33679cdcfe79ffef3e305861bfd0d0dac61e5d..2b60542bf80190c29a7ee9e49a1185ec9d6e868e 100644 (file)
--- a/kernel/irq/chip.c
+++ b/kernel/irq/chip.c
@@ -1106,53 +1106,40 @@ void irq_cpu_offline(void)
 
 #ifdef CONFIG_IRQ_FASTEOI_HIERARCHY_HANDLERS
 /**
- *     handle_fasteoi_ack_irq - irq handler for edge hierarchy
- *     stacked on transparent controllers
+ * handle_fasteoi_ack_irq - irq handler for edge hierarchy stacked on
+ *                         transparent controllers
  *
- *     @desc:  the interrupt description structure for this irq
+ * @desc:      the interrupt description structure for this irq
  *
- *     Like handle_fasteoi_irq(), but for use with hierarchy where
- *     the irq_chip also needs to have its ->irq_ack() function
- *     called.
+ * Like handle_fasteoi_irq(), but for use with hierarchy where the irq_chip
+ * also needs to have its ->irq_ack() function called.
  */
 void handle_fasteoi_ack_irq(struct irq_desc *desc)
 {
        struct irq_chip *chip = desc->irq_data.chip;
 
-       raw_spin_lock(&desc->lock);
-
-       if (!irq_can_handle_pm(desc))
-               goto out;
+       guard(raw_spinlock)(&desc->lock);
 
-       desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
+       if (!irq_can_handle_pm(desc)) {
+               cond_eoi_irq(chip, &desc->irq_data);
+               return;
+       }
 
-       /*
-        * If its disabled or no action available
-        * then mask it and get out of here:
-        */
-       if (unlikely(!desc->action || irqd_irq_disabled(&desc->irq_data))) {
-               desc->istate |= IRQS_PENDING;
+       if (unlikely(!irq_can_handle_actions(desc))) {
                mask_irq(desc);
-               goto out;
+               cond_eoi_irq(chip, &desc->irq_data);
+               return;
        }
 
        kstat_incr_irqs_this_cpu(desc);
        if (desc->istate & IRQS_ONESHOT)
                mask_irq(desc);
 
-       /* Start handling the irq */
        desc->irq_data.chip->irq_ack(&desc->irq_data);
 
        handle_irq_event(desc);
 
        cond_unmask_eoi_irq(desc, chip);
-
-       raw_spin_unlock(&desc->lock);
-       return;
-out:
-       if (!(chip->flags & IRQCHIP_EOI_IF_HANDLED))
-               chip->irq_eoi(&desc->irq_data);
-       raw_spin_unlock(&desc->lock);
 }
 EXPORT_SYMBOL_GPL(handle_fasteoi_ack_irq);