]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
tracing: Use guard() rather than scoped_guard()
authorMathieu Desnoyers <mathieu.desnoyers@efficios.com>
Mon, 25 Nov 2024 14:25:14 +0000 (09:25 -0500)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Tue, 26 Nov 2024 01:16:56 +0000 (20:16 -0500)
Using scoped_guard() in the implementation of trace_##name() adds an
unnecessary level of indentation.

Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Michael Jeanson <mjeanson@efficios.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Yonghong Song <yhs@fb.com>
Cc: Paul E. McKenney <paulmck@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: bpf@vger.kernel.org
Cc: Joel Fernandes <joel@joelfernandes.org>
Cc: Jordan Rife <jrife@google.com>
Link: https://lore.kernel.org/20241125142514.2897143-1-mathieu.desnoyers@efficios.com
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
include/linux/tracepoint.h

index b2633a72e8719c9d1aa601ac47c81bffa8a8230d..e398f6e43f61ffb849352a50c7057eb73d4ea2cf 100644 (file)
@@ -259,8 +259,8 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
        {                                                               \
                if (static_branch_unlikely(&__tracepoint_##name.key)) { \
                        if (cond) {                                     \
-                               scoped_guard(preempt_notrace)           \
-                                       __DO_TRACE_CALL(name, TP_ARGS(args)); \
+                               guard(preempt_notrace)();               \
+                               __DO_TRACE_CALL(name, TP_ARGS(args));   \
                        }                                               \
                }                                                       \
                if (IS_ENABLED(CONFIG_LOCKDEP) && (cond)) {             \
@@ -275,8 +275,8 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
        {                                                               \
                might_fault();                                          \
                if (static_branch_unlikely(&__tracepoint_##name.key)) { \
-                       scoped_guard(rcu_tasks_trace)                   \
-                               __DO_TRACE_CALL(name, TP_ARGS(args));   \
+                       guard(rcu_tasks_trace)();                       \
+                       __DO_TRACE_CALL(name, TP_ARGS(args));           \
                }                                                       \
                if (IS_ENABLED(CONFIG_LOCKDEP)) {                       \
                        WARN_ONCE(!rcu_is_watching(),                   \