]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
irqchip/mips-gic: Check the return value of ioremap() in gic_of_init()
authorWilliam Dean <williamsukatube@163.com>
Sat, 23 Jul 2022 10:01:28 +0000 (18:01 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2022 13:15:29 +0000 (15:15 +0200)
[ Upstream commit 71349cc85e5930dce78ed87084dee098eba24b59 ]

The function ioremap() in gic_of_init() can fail, so
its return value should be checked.

Reported-by: Hacash Robot <hacashRobot@santino.com>
Signed-off-by: William Dean <williamsukatube@163.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220723100128.2964304-1-williamsukatube@163.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/irqchip/irq-mips-gic.c

index 8b08b31ea2baabfd730b5ee8b614b8972e4f2b5c..8ada91bdbe4d014c7f2108e3509f510d18826332 100644 (file)
@@ -766,6 +766,10 @@ static int __init gic_of_init(struct device_node *node,
        }
 
        mips_gic_base = ioremap(gic_base, gic_len);
+       if (!mips_gic_base) {
+               pr_err("Failed to ioremap gic_base\n");
+               return -ENOMEM;
+       }
 
        gicconfig = read_gic_config();
        gic_shared_intrs = gicconfig & GIC_CONFIG_NUMINTERRUPTS;