common: loop device work on zoned file systems

Remove the call to _require_non_zoned_device from _require_loop because
there is nothing that prevents loop device to work on file systems on
zoned devices.  But loop devices are not supported directly on top of
zoned block devices, so add a _require_non_zoned_device to generic/563
to not run that test on zoned block devices.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Zorro Lang <zlang@redhat.com>

diff --git a/common/rc b/common/rc
index 1b2e4508d7673106f1ddb0016fd54766546fbf80..765b9b3f0a6798ce45a2534fb41fc59424eab38f 100644 (file)
--- a/common/rc
+++ b/common/rc
@@ -2280,9 +2280,6 @@ _require_loop()
     else
        _notrun "This test requires loopback device support"
     fi
-
-    # loop device does not handle zone information
-    _require_non_zoned_device ${TEST_DEV}
 }
 
 # this test requires kernel support for a secondary filesystem

diff --git a/tests/generic/563 b/tests/generic/563
index 2056470df8259a2d7d2d2408ea1e40e1ab301bcd..95a928fba5627ed3bf7f192c76bf96149130d39d 100755 (executable)
--- a/tests/generic/563
+++ b/tests/generic/563
@@ -38,6 +38,10 @@ _require_loop
 # cgroup v2 writeback is only support on block devices so far
 _require_block_device $SCRATCH_DEV
 
+# this test creates a loop device on the scratch block device, which is not
+# supported on zoned devices
+_require_non_zoned_device ${SCRATCH_DEV}
+
 cgdir=$CGROUP2_PATH
 iosize=$((1024 * 1024 * 8))