]> www.infradead.org Git - users/sagi/libnvme.git/commitdiff
tree: fix mem leak in nvme_ns_init()
authorMartin George <marting@netapp.com>
Mon, 15 Apr 2024 06:58:43 +0000 (12:28 +0530)
committerDaniel Wagner <wagi@monom.org>
Mon, 15 Apr 2024 12:43:43 +0000 (14:43 +0200)
Valgrind revealed a mem leak in nvme_ns_init() invoked by
several nvme commands such as connect-all, list, disconnect-all,
etc. Leak traced to the nvme_ns_id pointer not getting freed
after use. Fix the same.

Signed-off-by: Martin George <marting@netapp.com>
src/nvme/tree.c

index 59387bf872b3b2d78e1a71e228c309a82913c3ef..2218d5a8145b5a2c57856856c1803a47e6d67f9c 100644 (file)
@@ -2488,7 +2488,7 @@ static int nvme_ns_init(const char *path, struct nvme_ns *ns)
                if (ret)
                        return ret;
        } else {
-               struct nvme_id_ns *id;
+               _cleanup_free_ struct nvme_id_ns *id = NULL;
                uint8_t flbas;
 
                id = __nvme_alloc(sizeof(*ns));