]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
RDMA/rtrs: Define MIN_CHUNK_SIZE
authorGioh Kim <gi-oh.kim@cloud.ionos.com>
Fri, 28 May 2021 11:30:04 +0000 (13:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2022 13:16:00 +0000 (15:16 +0200)
[ Upstream commit 3f3d0eabc14b6ea1fcbe85a60ee9d44e2b930b8a ]

Define MIN_CHUNK_SIZE to replace the hard-coding number.
We need 4k for metadata, so MIN_CHUNK_SIZE should be at least 8k.

Link: https://lore.kernel.org/r/20210528113018.52290-7-jinpu.wang@ionos.com
Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/ulp/rtrs/rtrs-pri.h
drivers/infiniband/ulp/rtrs/rtrs-srv.c

index 51c60f5428761cd51bcd0b66145103e858526d94..333de9d521724c9df4011168f91008d7baf134b4 100644 (file)
@@ -56,6 +56,7 @@ enum {
         * somewhere between 1 and 65536 and it depends on the system.
         */
        MAX_SESS_QUEUE_DEPTH = 65536,
+       MIN_CHUNK_SIZE = 8192,
 
        RTRS_HB_INTERVAL_MS = 5000,
        RTRS_HB_MISSED_MAX = 5,
index b033bfa9f383965e3012b561887ec5027b7619c9..b152a742cd3c539827397a73ddebf923b4f6e503 100644 (file)
@@ -2193,9 +2193,9 @@ static int check_module_params(void)
                       sess_queue_depth, 1, MAX_SESS_QUEUE_DEPTH);
                return -EINVAL;
        }
-       if (max_chunk_size < 4096 || !is_power_of_2(max_chunk_size)) {
+       if (max_chunk_size < MIN_CHUNK_SIZE || !is_power_of_2(max_chunk_size)) {
                pr_err("Invalid max_chunk_size value %d, has to be >= %d and should be power of two.\n",
-                      max_chunk_size, 4096);
+                      max_chunk_size, MIN_CHUNK_SIZE);
                return -EINVAL;
        }