]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
IB/mlx4: Fix incorrect order of formal and actual parameters
authorHåkon Bugge <haakon.bugge@oracle.com>
Fri, 28 Apr 2017 11:06:54 +0000 (13:06 +0200)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 8 Jun 2017 06:32:17 +0000 (23:32 -0700)
The last two actual parameters when calling id_map_find_by_sl_id()
from id_map_get() are swapped. However, the same formal parameters to
id_map_get() have them swapped as well, inverting the effect of the
first error.

This commit improves readability, but makes no functional change to
the code.

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Reviewed-by: Wengang Wang <wen.gang.wang@oracle.com>
Reviewed-by: Knut Omang <knut.omang@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
(cherry picked from commit b03ee4ca0cec348c84dccf08aaec2454c4d236c2)

Orabug: 26187991

Reviewed-by: Wei Lin Guay <wei.lin.guay@oracle.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
drivers/infiniband/hw/mlx4/cm.c

index 39a488889fc7a9981213b25567f051dc772bc510..305b0c643231ace5022a031a5d96943f7cdb507b 100644 (file)
@@ -281,14 +281,14 @@ id_map_alloc(struct ib_device *ibdev, int slave_id, u32 sl_cm_id)
 }
 
 static struct id_map_entry *
-id_map_get(struct ib_device *ibdev, int *pv_cm_id, int sl_cm_id, int slave_id)
+id_map_get(struct ib_device *ibdev, int *pv_cm_id, int slave_id, int sl_cm_id)
 {
        struct id_map_entry *ent;
        struct mlx4_ib_sriov *sriov = &to_mdev(ibdev)->sriov;
 
        spin_lock(&sriov->id_map_lock);
        if (*pv_cm_id == -1) {
-               ent = id_map_find_by_sl_id(ibdev, sl_cm_id, slave_id);
+               ent = id_map_find_by_sl_id(ibdev, slave_id, sl_cm_id);
                if (ent)
                        *pv_cm_id = (int) ent->pv_cm_id;
        } else