]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
io_uring/region: return negative -E2BIG in io_create_region()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 20 Nov 2024 09:15:05 +0000 (12:15 +0300)
committerJens Axboe <axboe@kernel.dk>
Wed, 20 Nov 2024 15:01:59 +0000 (08:01 -0700)
This code accidentally returns positivie E2BIG instead of negative
-E2BIG.  The callers treat negatives and positives the same so this
doesn't affect the kernel.  The error code is returned to userspace via
the system call.

Fixes: dfbbfbf19187 ("io_uring: introduce concept of memory regions")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/d8ea3bef-74d8-4f77-8223-6d36464dd4dc@stanley.mountain
Signed-off-by: Jens Axboe <axboe@kernel.dk>
io_uring/memmap.c

index 6e6ee79ba94fcd97a57811a4bf98fd3a0abf0bdb..3d71756bc598ac3ed5425bd30a69048dafba4f6c 100644 (file)
@@ -229,7 +229,7 @@ int io_create_region(struct io_ring_ctx *ctx, struct io_mapped_region *mr,
        if (!reg->size || reg->mmap_offset || reg->id)
                return -EINVAL;
        if ((reg->size >> PAGE_SHIFT) > INT_MAX)
-               return E2BIG;
+               return -E2BIG;
        if ((reg->user_addr | reg->size) & ~PAGE_MASK)
                return -EINVAL;
        if (check_add_overflow(reg->user_addr, reg->size, &end))