]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: lpspi: fix the imbalance of runtime pm function call
authorClark Wang <xiaoning.wang@nxp.com>
Tue, 14 Jul 2020 07:52:47 +0000 (15:52 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 22 Jul 2020 00:55:50 +0000 (01:55 +0100)
Call the put function after probe successfully. Otherwise, the lpspi
module will keep active status until the first spi transfer called.

Disable runtime pm when probe fails. There is no need to active runtime
pm after probe failed.

Signed-off-by: Clark Wang <xiaoning.wang@nxp.com>
Link: https://lore.kernel.org/r/20200714075251.12777-2-xiaoning.wang@nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-lpspi.c

index 38b44446c947df23498239e9ed9a50a58ea1fbe7..a4a42e85e132d6c46975c929a4e2bc68fa652415 100644 (file)
@@ -913,10 +913,15 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
        if (ret < 0)
                dev_err(&pdev->dev, "dma setup error %d, use pio\n", ret);
 
+       pm_runtime_mark_last_busy(fsl_lpspi->dev);
+       pm_runtime_put_autosuspend(fsl_lpspi->dev);
+
        return 0;
 
 out_pm_get:
-       pm_runtime_put_noidle(fsl_lpspi->dev);
+       pm_runtime_dont_use_autosuspend(fsl_lpspi->dev);
+       pm_runtime_put_sync(fsl_lpspi->dev);
+       pm_runtime_disable(fsl_lpspi->dev);
 out_controller_put:
        spi_controller_put(controller);