]> www.infradead.org Git - users/hch/xfs.git/commitdiff
xfs: factor out rtbitmap/summary initialization helpers
authorChristoph Hellwig <hch@lst.de>
Fri, 30 Aug 2024 22:36:59 +0000 (15:36 -0700)
committerDarrick J. Wong <djwong@kernel.org>
Sun, 1 Sep 2024 15:58:19 +0000 (08:58 -0700)
Add helpers to libxfs that can be shared by growfs and mkfs for
initializing the rtbitmap and summary, and by passing the optional data
pointer also by repair for rebuilding them.  This will become even more
useful when the rtgroups feature adds a metadata header to each block,
which means even more shared code.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
[djwong: minor documentation and data advance tweaks]
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
fs/xfs/libxfs/xfs_rtbitmap.c
fs/xfs/libxfs/xfs_rtbitmap.h
fs/xfs/xfs_rtalloc.c

index 02d6668d860fd1537079e7275807b0bfacd5be80..715d2c54ce029899279f834e7629aac6fd063c59 100644 (file)
@@ -13,6 +13,8 @@
 #include "xfs_mount.h"
 #include "xfs_inode.h"
 #include "xfs_bmap.h"
+#include "xfs_bmap_btree.h"
+#include "xfs_trans_space.h"
 #include "xfs_trans.h"
 #include "xfs_rtalloc.h"
 #include "xfs_error.h"
@@ -1255,3 +1257,127 @@ xfs_rtbitmap_unlock_shared(
        if (rbmlock_flags & XFS_RBMLOCK_BITMAP)
                xfs_iunlock(mp->m_rbmip, XFS_ILOCK_SHARED | XFS_ILOCK_RTBITMAP);
 }
+
+static int
+xfs_rtfile_alloc_blocks(
+       struct xfs_inode        *ip,
+       xfs_fileoff_t           offset_fsb,
+       xfs_filblks_t           count_fsb,
+       struct xfs_bmbt_irec    *map)
+{
+       struct xfs_mount        *mp = ip->i_mount;
+       struct xfs_trans        *tp;
+       int                     nmap = 1;
+       int                     error;
+
+       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growrtalloc,
+                       XFS_GROWFSRT_SPACE_RES(mp, count_fsb), 0, 0, &tp);
+       if (error)
+               return error;
+
+       xfs_ilock(ip, XFS_ILOCK_EXCL);
+       xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
+
+       error = xfs_iext_count_extend(tp, ip, XFS_DATA_FORK,
+                               XFS_IEXT_ADD_NOSPLIT_CNT);
+       if (error)
+               goto out_trans_cancel;
+
+       error = xfs_bmapi_write(tp, ip, offset_fsb, count_fsb,
+                       XFS_BMAPI_METADATA, 0, map, &nmap);
+       if (error)
+               goto out_trans_cancel;
+
+       return xfs_trans_commit(tp);
+
+out_trans_cancel:
+       xfs_trans_cancel(tp);
+       return error;
+}
+
+/* Get a buffer for the block. */
+static int
+xfs_rtfile_initialize_block(
+       struct xfs_inode        *ip,
+       xfs_fsblock_t           fsbno,
+       void                    *data)
+{
+       struct xfs_mount        *mp = ip->i_mount;
+       struct xfs_trans        *tp;
+       struct xfs_buf          *bp;
+       const size_t            copylen = mp->m_blockwsize << XFS_WORDLOG;
+       enum xfs_blft           buf_type;
+       int                     error;
+
+       if (ip == mp->m_rsumip)
+               buf_type = XFS_BLFT_RTSUMMARY_BUF;
+       else
+               buf_type = XFS_BLFT_RTBITMAP_BUF;
+
+       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growrtzero, 0, 0, 0, &tp);
+       if (error)
+               return error;
+       xfs_ilock(ip, XFS_ILOCK_EXCL);
+       xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
+
+       error = xfs_trans_get_buf(tp, mp->m_ddev_targp,
+                       XFS_FSB_TO_DADDR(mp, fsbno), mp->m_bsize, 0, &bp);
+       if (error) {
+               xfs_trans_cancel(tp);
+               return error;
+       }
+
+       xfs_trans_buf_set_type(tp, bp, buf_type);
+       bp->b_ops = &xfs_rtbuf_ops;
+       if (data)
+               memcpy(bp->b_addr, data, copylen);
+       else
+               memset(bp->b_addr, 0, copylen);
+       xfs_trans_log_buf(tp, bp, 0, mp->m_sb.sb_blocksize - 1);
+       return xfs_trans_commit(tp);
+}
+
+/*
+ * Allocate space to the bitmap or summary file, and zero it, for growfs.
+ * @data must be a contiguous buffer large enough to fill all blocks in the
+ * file; or NULL to initialize the contents to zeroes.
+ */
+int
+xfs_rtfile_initialize_blocks(
+       struct xfs_inode        *ip,            /* inode (bitmap/summary) */
+       xfs_fileoff_t           offset_fsb,     /* offset to start from */
+       xfs_fileoff_t           end_fsb,        /* offset to allocate to */
+       void                    *data)          /* data to fill the blocks */
+{
+       struct xfs_mount        *mp = ip->i_mount;
+       const size_t            copylen = mp->m_blockwsize << XFS_WORDLOG;
+
+       while (offset_fsb < end_fsb) {
+               struct xfs_bmbt_irec    map;
+               xfs_filblks_t           i;
+               int                     error;
+
+               error = xfs_rtfile_alloc_blocks(ip, offset_fsb,
+                               end_fsb - offset_fsb, &map);
+               if (error)
+                       return error;
+
+               /*
+                * Now we need to clear the allocated blocks.
+                *
+                * Do this one block per transaction, to keep it simple.
+                */
+               for (i = 0; i < map.br_blockcount; i++) {
+                       error = xfs_rtfile_initialize_block(ip,
+                                       map.br_startblock + i, data);
+                       if (error)
+                               return error;
+                       if (data)
+                               data += copylen;
+               }
+
+               offset_fsb = map.br_startoff + map.br_blockcount;
+       }
+
+       return 0;
+}
index e87e2099cff5e083553bc2d8dd89fdb7e38f6033..0d5ab5e2cb6a329eae5a523508c2ab744f2067dc 100644 (file)
@@ -343,6 +343,9 @@ xfs_filblks_t xfs_rtsummary_blockcount(struct xfs_mount *mp,
 unsigned long long xfs_rtsummary_wordcount(struct xfs_mount *mp,
                unsigned int rsumlevels, xfs_extlen_t rbmblocks);
 
+int xfs_rtfile_initialize_blocks(struct xfs_inode *ip,
+               xfs_fileoff_t offset_fsb, xfs_fileoff_t end_fsb, void *data);
+
 void xfs_rtbitmap_lock(struct xfs_trans *tp, struct xfs_mount *mp);
 void xfs_rtbitmap_unlock(struct xfs_mount *mp);
 
index 45a0d29949ea0d55e221428fd605201082b2d0c7..114807cd80bac8ee839607e6825d65b63106b6c0 100644 (file)
@@ -641,121 +641,6 @@ xfs_rtallocate_extent_size(
        return -ENOSPC;
 }
 
-/*
- * Allocate space to the bitmap or summary file, and zero it, for growfs.
- */
-STATIC int
-xfs_growfs_rt_alloc(
-       struct xfs_mount        *mp,            /* file system mount point */
-       xfs_extlen_t            oblocks,        /* old count of blocks */
-       xfs_extlen_t            nblocks,        /* new count of blocks */
-       struct xfs_inode        *ip)            /* inode (bitmap/summary) */
-{
-       xfs_fileoff_t           bno;            /* block number in file */
-       struct xfs_buf          *bp;    /* temporary buffer for zeroing */
-       xfs_daddr_t             d;              /* disk block address */
-       int                     error;          /* error return value */
-       xfs_fsblock_t           fsbno;          /* filesystem block for bno */
-       struct xfs_bmbt_irec    map;            /* block map output */
-       int                     nmap;           /* number of block maps */
-       int                     resblks;        /* space reservation */
-       enum xfs_blft           buf_type;
-       struct xfs_trans        *tp;
-
-       if (ip == mp->m_rsumip)
-               buf_type = XFS_BLFT_RTSUMMARY_BUF;
-       else
-               buf_type = XFS_BLFT_RTBITMAP_BUF;
-
-       /*
-        * Allocate space to the file, as necessary.
-        */
-       while (oblocks < nblocks) {
-               resblks = XFS_GROWFSRT_SPACE_RES(mp, nblocks - oblocks);
-               /*
-                * Reserve space & log for one extent added to the file.
-                */
-               error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growrtalloc, resblks,
-                               0, 0, &tp);
-               if (error)
-                       return error;
-               /*
-                * Lock the inode.
-                */
-               xfs_ilock(ip, XFS_ILOCK_EXCL);
-               xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
-
-               error = xfs_iext_count_extend(tp, ip, XFS_DATA_FORK,
-                               XFS_IEXT_ADD_NOSPLIT_CNT);
-               if (error)
-                       goto out_trans_cancel;
-
-               /*
-                * Allocate blocks to the bitmap file.
-                */
-               nmap = 1;
-               error = xfs_bmapi_write(tp, ip, oblocks, nblocks - oblocks,
-                                       XFS_BMAPI_METADATA, 0, &map, &nmap);
-               if (error)
-                       goto out_trans_cancel;
-               /*
-                * Free any blocks freed up in the transaction, then commit.
-                */
-               error = xfs_trans_commit(tp);
-               if (error)
-                       return error;
-               /*
-                * Now we need to clear the allocated blocks.
-                * Do this one block per transaction, to keep it simple.
-                */
-               for (bno = map.br_startoff, fsbno = map.br_startblock;
-                    bno < map.br_startoff + map.br_blockcount;
-                    bno++, fsbno++) {
-                       /*
-                        * Reserve log for one block zeroing.
-                        */
-                       error = xfs_trans_alloc(mp, &M_RES(mp)->tr_growrtzero,
-                                       0, 0, 0, &tp);
-                       if (error)
-                               return error;
-                       /*
-                        * Lock the bitmap inode.
-                        */
-                       xfs_ilock(ip, XFS_ILOCK_EXCL);
-                       xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL);
-                       /*
-                        * Get a buffer for the block.
-                        */
-                       d = XFS_FSB_TO_DADDR(mp, fsbno);
-                       error = xfs_trans_get_buf(tp, mp->m_ddev_targp, d,
-                                       mp->m_bsize, 0, &bp);
-                       if (error)
-                               goto out_trans_cancel;
-
-                       xfs_trans_buf_set_type(tp, bp, buf_type);
-                       bp->b_ops = &xfs_rtbuf_ops;
-                       memset(bp->b_addr, 0, mp->m_sb.sb_blocksize);
-                       xfs_trans_log_buf(tp, bp, 0, mp->m_sb.sb_blocksize - 1);
-                       /*
-                        * Commit the transaction.
-                        */
-                       error = xfs_trans_commit(tp);
-                       if (error)
-                               return error;
-               }
-               /*
-                * Go on to the next extent, if any.
-                */
-               oblocks = map.br_startoff + map.br_blockcount;
-       }
-
-       return 0;
-
-out_trans_cancel:
-       xfs_trans_cancel(tp);
-       return error;
-}
-
 static int
 xfs_alloc_rsum_cache(
        struct xfs_mount        *mp,
@@ -1062,10 +947,12 @@ xfs_growfs_rt(
        /*
         * Allocate space to the bitmap and summary files, as necessary.
         */
-       error = xfs_growfs_rt_alloc(mp, rbmblocks, nrbmblocks, mp->m_rbmip);
+       error = xfs_rtfile_initialize_blocks(mp->m_rbmip, rbmblocks,
+                       nrbmblocks, NULL);
        if (error)
                goto out_unlock;
-       error = xfs_growfs_rt_alloc(mp, rsumblocks, nrsumblocks, mp->m_rsumip);
+       error = xfs_rtfile_initialize_blocks(mp->m_rsumip, rsumblocks,
+                       nrsumblocks, NULL);
        if (error)
                goto out_unlock;