]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: adc: ti-ads124s08: Use gpiod_set_value_cansleep()
authorFabio Estevam <festevam@gmail.com>
Fri, 22 Nov 2024 16:43:08 +0000 (13:43 -0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 7 Dec 2024 17:23:42 +0000 (17:23 +0000)
Using gpiod_set_value() to control the reset GPIO causes some verbose
warnings during boot when the reset GPIO is controlled by an I2C IO
expander.

As the caller can sleep, use the gpiod_set_value_cansleep() variant to
fix the issue.

Tested on a custom i.MX93 board with a ADS124S08 ADC.

Cc: stable@kernel.org
Fixes: e717f8c6dfec ("iio: adc: Add the TI ads124s08 ADC code")
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Link: https://patch.msgid.link/20241122164308.390340-1-festevam@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ti-ads124s08.c

index 425b48d8986f5249b721d1f4322a0a8d4400386c..f452f57f11c95624dbef9077f077d563785530fe 100644 (file)
@@ -183,9 +183,9 @@ static int ads124s_reset(struct iio_dev *indio_dev)
        struct ads124s_private *priv = iio_priv(indio_dev);
 
        if (priv->reset_gpio) {
-               gpiod_set_value(priv->reset_gpio, 0);
+               gpiod_set_value_cansleep(priv->reset_gpio, 0);
                udelay(200);
-               gpiod_set_value(priv->reset_gpio, 1);
+               gpiod_set_value_cansleep(priv->reset_gpio, 1);
        } else {
                return ads124s_write_cmd(indio_dev, ADS124S08_CMD_RESET);
        }