drm/vblank: Add FIXME comments about moving the vblank ts hooks

This is going to be a bit too much, but good to have at least a small
note about where this should all head towards.

Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170509140329.24114-3-daniel.vetter@ffwll.ch

diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h
index a97dbc1eeccd39f3cea0d6373415aeb29408fdb5..619da98533cd5374146161dc4008451715510565 100644 (file)
--- a/include/drm/drm_drv.h
+++ b/include/drm/drm_drv.h
@@ -276,6 +276,11 @@ struct drm_driver {
         *     constant but unknown small number of scanlines wrt. real scanout
         *     position.
         *
+        * FIXME:
+        *
+        * Since this is a helper to implement @get_vblank_timestamp, we should
+        * move it to &struct drm_crtc_helper_funcs, like all the other
+        * helper-internal hooks.
         */
        int (*get_scanout_position) (struct drm_device *dev, unsigned int pipe,
                                     unsigned int flags, int *vpos, int *hpos,
@@ -319,6 +324,11 @@ struct drm_driver {
         *
         * True on success, false on failure, which means the core should
         * fallback to a simple timestamp taken in drm_crtc_handle_vblank().
+        *
+        * FIXME:
+        *
+        * We should move this hook to &struct drm_crtc_funcs like all the other
+        * vblank hooks.
         */
        bool (*get_vblank_timestamp) (struct drm_device *dev, unsigned int pipe,
                                     int *max_error,