net: mtk_eth_soc: use ethtool_puts

Allows simplifying get_strings and avoids manual pointer manipulation.

Tested on Belkin RT1800.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
Link: https://patch.msgid.link/20241011200225.7403-1-rosenp@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index a476a94a607d44d1231e7a30608a540883e2c34a..e35a2e4d5525b90e46f8453ed3adcdbbd272a4c8 100644 (file)
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -4329,10 +4329,8 @@ static void mtk_get_strings(struct net_device *dev, u32 stringset, u8 *data)
        case ETH_SS_STATS: {
                struct mtk_mac *mac = netdev_priv(dev);
 
-               for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++) {
-                       memcpy(data, mtk_ethtool_stats[i].str, ETH_GSTRING_LEN);
-                       data += ETH_GSTRING_LEN;
-               }
+               for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++)
+                       ethtool_puts(&data, mtk_ethtool_stats[i].str);
                if (mtk_page_pool_enabled(mac->hw))
                        page_pool_ethtool_stats_get_strings(data);
                break;