]> www.infradead.org Git - users/hch/misc.git/commitdiff
drm/sysfb: Remove double assignment to pointer crtc_state
authorColin Ian King <colin.i.king@gmail.com>
Wed, 3 Sep 2025 08:31:06 +0000 (09:31 +0100)
committerThomas Zimmermann <tzimmermann@suse.de>
Thu, 4 Sep 2025 07:26:39 +0000 (09:26 +0200)
The declaration of pointer crtc_state includes an assignment to
crtc_state. The double assignment of crtc_state is redundant and
can be removed.

Fixes: 061963cd9e5b ("drm/sysfb: Blit to CRTC destination format")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20250903083106.2703580-1-colin.i.king@gmail.com
drivers/gpu/drm/sysfb/drm_sysfb_modeset.c

index 963c380fea64ee9865e47b44c5c735bf39f74fba..ddb4a7523ee612ce96c66ebd74a436ff1e70a16e 100644 (file)
@@ -238,8 +238,7 @@ void drm_sysfb_plane_helper_atomic_update(struct drm_plane *plane, struct drm_at
        struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(plane_state);
        struct drm_framebuffer *fb = plane_state->fb;
        unsigned int dst_pitch = sysfb->fb_pitch;
-       struct drm_crtc_state *crtc_state = crtc_state =
-               drm_atomic_get_new_crtc_state(state, plane_state->crtc);
+       struct drm_crtc_state *crtc_state = drm_atomic_get_new_crtc_state(state, plane_state->crtc);
        struct drm_sysfb_crtc_state *sysfb_crtc_state = to_drm_sysfb_crtc_state(crtc_state);
        const struct drm_format_info *dst_format = sysfb_crtc_state->format;
        struct drm_atomic_helper_damage_iter iter;