]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: mxs-saif: Fix refcount leak in mxs_saif_probe
authorMiaoqian Lin <linmq006@gmail.com>
Wed, 11 May 2022 13:37:22 +0000 (17:37 +0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 9 Jun 2022 08:21:07 +0000 (10:21 +0200)
[ Upstream commit 2be84f73785fa9ed6443e3c5b158730266f1c2ee ]

of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.

Fixes: 08641c7c74dd ("ASoC: mxs: add device tree support for mxs-saif")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220511133725.39039-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/mxs/mxs-saif.c

index f2eda81985e27fd151a5ce7430c9f2a2ea516396..d87ac26999cfd9b557442f78eda2d8062e0aa323 100644 (file)
@@ -764,6 +764,7 @@ static int mxs_saif_probe(struct platform_device *pdev)
                saif->master_id = saif->id;
        } else {
                ret = of_alias_get_id(master, "saif");
+               of_node_put(master);
                if (ret < 0)
                        return ret;
                else