ASoC: max9867: keep ADCs and DACs always on

Updating power management register requires toggling the shutdown
bit otherwise it causes unexpected behavior of the codec.
However, toggling the shutdown bit results in loud speaker crackling.
Setup the power management register only at startup to avoid that.

Signed-off-by: Pavel Dobias <dobias@2n.cz>
Link: https://lore.kernel.org/r/20200522142957.18364-3-dobias@2n.cz
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/max9867.c b/sound/soc/codecs/max9867.c
index 93dd3d401f197daf734048c60d1f01d1b1de78c1..dc05c57db03ac5e032fcdf842bea696bf0fa0587 100644 (file)
--- a/sound/soc/codecs/max9867.c
+++ b/sound/soc/codecs/max9867.c
@@ -125,8 +125,8 @@ static const struct snd_soc_dapm_widget max9867_dapm_widgets[] = {
        SND_SOC_DAPM_INPUT("LINL"),
        SND_SOC_DAPM_INPUT("LINR"),
 
-       SND_SOC_DAPM_PGA("Left Line Input", MAX9867_PWRMAN, 6, 0, NULL, 0),
-       SND_SOC_DAPM_PGA("Right Line Input", MAX9867_PWRMAN, 5, 0, NULL, 0),
+       SND_SOC_DAPM_PGA("Left Line Input", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_PGA("Right Line Input", SND_SOC_NOPM, 0, 0, NULL, 0),
        SND_SOC_DAPM_MIXER_NAMED_CTL("Input Mixer", SND_SOC_NOPM, 0, 0,
                                     max9867_input_mixer_controls,
                                     ARRAY_SIZE(max9867_input_mixer_controls)),
@@ -134,8 +134,8 @@ static const struct snd_soc_dapm_widget max9867_dapm_widgets[] = {
                         &max9867_left_dmic_mux),
        SND_SOC_DAPM_MUX("DMICR Mux", SND_SOC_NOPM, 0, 0,
                         &max9867_right_dmic_mux),
-       SND_SOC_DAPM_ADC("ADCL", "HiFi Capture", MAX9867_PWRMAN, 1, 0),
-       SND_SOC_DAPM_ADC("ADCR", "HiFi Capture", MAX9867_PWRMAN, 0, 0),
+       SND_SOC_DAPM_ADC("ADCL", "HiFi Capture", SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_ADC("ADCR", "HiFi Capture", SND_SOC_NOPM, 0, 0),
 
        SND_SOC_DAPM_MIXER("Digital", SND_SOC_NOPM, 0, 0,
                           max9867_sidetone_mixer_controls,
@@ -143,8 +143,8 @@ static const struct snd_soc_dapm_widget max9867_dapm_widgets[] = {
        SND_SOC_DAPM_MIXER_NAMED_CTL("Output Mixer", SND_SOC_NOPM, 0, 0,
                                     max9867_output_mixer_controls,
                                     ARRAY_SIZE(max9867_output_mixer_controls)),
-       SND_SOC_DAPM_DAC("DACL", "HiFi Playback", MAX9867_PWRMAN, 3, 0),
-       SND_SOC_DAPM_DAC("DACR", "HiFi Playback", MAX9867_PWRMAN, 2, 0),
+       SND_SOC_DAPM_DAC("DACL", "HiFi Playback", SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_DAC("DACR", "HiFi Playback", SND_SOC_NOPM, 0, 0),
        SND_SOC_DAPM_SWITCH("Master Playback", SND_SOC_NOPM, 0, 0,
                            &max9867_line_out_control),
        SND_SOC_DAPM_OUTPUT("LOUT"),
@@ -452,15 +452,14 @@ static int max9867_set_bias_level(struct snd_soc_component *component,
                        if (err)
                                return err;
 
-                       err = regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
-                                                MAX9867_SHTDOWN, MAX9867_SHTDOWN);
+                       err = regmap_write(max9867->regmap,
+                                          MAX9867_PWRMAN, 0xff);
                        if (err)
                                return err;
                }
                break;
        case SND_SOC_BIAS_OFF:
-               err = regmap_update_bits(max9867->regmap, MAX9867_PWRMAN,
-                                        MAX9867_SHTDOWN, 0);
+               err = regmap_write(max9867->regmap, MAX9867_PWRMAN, 0);
                if (err)
                        return err;
 

diff --git a/sound/soc/codecs/max9867.h b/sound/soc/codecs/max9867.h
index d459d49449cbef0872e8d662fda06958aabec39d..3092c3b9907520a7dfd0c203c8bb9f26bdcb3cb9 100644 (file)
--- a/sound/soc/codecs/max9867.h
+++ b/sound/soc/codecs/max9867.h
@@ -58,7 +58,6 @@
 #define MAX9867_MICCONFIG    0x15
 #define MAX9867_MODECONFIG   0x16
 #define MAX9867_PWRMAN       0x17
-#define MAX9867_SHTDOWN      0x80
 #define MAX9867_REVISION     0xff
 
 #define MAX9867_CACHEREGNUM 10