btrfs: pass btrfs_inode to btrfs_inode_lock

The function is for internal interfaces so we should use the
btrfs_inode.

Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs/btrfs_inode.h
index 9fe1a11a2eb37af31ed882f1ca424ae7b39fe064..a06d1c0a0cc2b6c5ce60348af7c226df7989a294 100644 (file)
--- a/fs/btrfs/btrfs_inode.h
+++ b/fs/btrfs/btrfs_inode.h
@@ -545,7 +545,7 @@ enum btrfs_ilock_type {
        ENUM_BIT(BTRFS_ILOCK_MMAP),
 };
 
-int btrfs_inode_lock(struct inode *inode, unsigned int ilock_flags);
+int btrfs_inode_lock(struct btrfs_inode *inode, unsigned int ilock_flags);
 void btrfs_inode_unlock(struct inode *inode, unsigned int ilock_flags);
 void btrfs_update_inode_bytes(struct btrfs_inode *inode, const u64 add_bytes,
                              const u64 del_bytes);

diff --git a/fs/btrfs/defrag.c b/fs/btrfs/defrag.c
index 919dfe0f7e5054caaabc4e00b3696c423f7cfa8d..6aade48389275ae2de49050179b9c8c117b5dd96 100644 (file)
--- a/fs/btrfs/defrag.c
+++ b/fs/btrfs/defrag.c
@@ -1295,7 +1295,7 @@ int btrfs_defrag_file(struct inode *inode, struct file_ra_state *ra,
                               (SZ_256K >> PAGE_SHIFT)) << PAGE_SHIFT) - 1;
                cluster_end = min(cluster_end, last_byte);
 
-               btrfs_inode_lock(inode, 0);
+               btrfs_inode_lock(BTRFS_I(inode), 0);
                if (IS_SWAPFILE(inode)) {
                        ret = -ETXTBSY;
                        btrfs_inode_unlock(inode, 0);
@@ -1351,7 +1351,7 @@ int btrfs_defrag_file(struct inode *inode, struct file_ra_state *ra,
                ret = sectors_defragged;
        }
        if (do_compress) {
-               btrfs_inode_lock(inode, 0);
+               btrfs_inode_lock(BTRFS_I(inode), 0);
                BTRFS_I(inode)->defrag_compress = BTRFS_COMPRESS_NONE;
                btrfs_inode_unlock(inode, 0);
        }

diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index c024f97de9e0ebbf6f785deddd54e5d3c041f861..4edf44d8cd9eb680b82e7f0eada79182b0d5e32c 100644 (file)
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -1647,7 +1647,7 @@ bool btrfs_readdir_get_delayed_items(struct inode *inode,
         * item->readdir_list.
         */
        btrfs_inode_unlock(inode, BTRFS_ILOCK_SHARED);
-       btrfs_inode_lock(inode, 0);
+       btrfs_inode_lock(BTRFS_I(inode), 0);
 
        mutex_lock(&delayed_node->mutex);
        item = __btrfs_first_delayed_insertion_item(delayed_node);

diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index f8be9d629e7572246925c93e56dcbd5804f49400..b3b7b276cce0eaf3263453c0d4d20de49346ca11 100644 (file)
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -1193,7 +1193,7 @@ static noinline ssize_t btrfs_buffered_write(struct kiocb *iocb,
        if (nowait)
                ilock_flags |= BTRFS_ILOCK_TRY;
 
-       ret = btrfs_inode_lock(inode, ilock_flags);
+       ret = btrfs_inode_lock(BTRFS_I(inode), ilock_flags);
        if (ret < 0)
                return ret;
 
@@ -1468,7 +1468,7 @@ static ssize_t btrfs_direct_write(struct kiocb *iocb, struct iov_iter *from)
                ilock_flags |= BTRFS_ILOCK_SHARED;
 
 relock:
-       err = btrfs_inode_lock(inode, ilock_flags);
+       err = btrfs_inode_lock(BTRFS_I(inode), ilock_flags);
        if (err < 0)
                return err;
 
@@ -1616,7 +1616,7 @@ static ssize_t btrfs_encoded_write(struct kiocb *iocb, struct iov_iter *from,
        loff_t count;
        ssize_t ret;
 
-       btrfs_inode_lock(inode, 0);
+       btrfs_inode_lock(BTRFS_I(inode), 0);
        count = encoded->len;
        ret = generic_write_checks_count(iocb, &count);
        if (ret == 0 && count != encoded->len) {
@@ -1806,7 +1806,7 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
        if (ret)
                goto out;
 
-       btrfs_inode_lock(inode, BTRFS_ILOCK_MMAP);
+       btrfs_inode_lock(BTRFS_I(inode), BTRFS_ILOCK_MMAP);
 
        atomic_inc(&root->log_batch);
 
@@ -2596,7 +2596,7 @@ static int btrfs_punch_hole(struct file *file, loff_t offset, loff_t len)
        bool truncated_block = false;
        bool updated_inode = false;
 
-       btrfs_inode_lock(inode, BTRFS_ILOCK_MMAP);
+       btrfs_inode_lock(BTRFS_I(inode), BTRFS_ILOCK_MMAP);
 
        ret = btrfs_wait_ordered_range(inode, offset, len);
        if (ret)
@@ -3054,7 +3054,7 @@ static long btrfs_fallocate(struct file *file, int mode,
        if (mode & FALLOC_FL_PUNCH_HOLE)
                return btrfs_punch_hole(file, offset, len);
 
-       btrfs_inode_lock(inode, BTRFS_ILOCK_MMAP);
+       btrfs_inode_lock(BTRFS_I(inode), BTRFS_ILOCK_MMAP);
 
        if (!(mode & FALLOC_FL_KEEP_SIZE) && offset + len > inode->i_size) {
                ret = inode_newsize_ok(inode, offset + len);
@@ -3691,7 +3691,7 @@ static loff_t btrfs_file_llseek(struct file *file, loff_t offset, int whence)
                return generic_file_llseek(file, offset, whence);
        case SEEK_DATA:
        case SEEK_HOLE:
-               btrfs_inode_lock(inode, BTRFS_ILOCK_SHARED);
+               btrfs_inode_lock(BTRFS_I(inode), BTRFS_ILOCK_SHARED);
                offset = find_desired_extent(BTRFS_I(inode), offset, whence);
                btrfs_inode_unlock(inode, BTRFS_ILOCK_SHARED);
                break;
@@ -3748,7 +3748,7 @@ static ssize_t btrfs_direct_read(struct kiocb *iocb, struct iov_iter *to)
        if (check_direct_read(btrfs_sb(inode->i_sb), to, iocb->ki_pos))
                return 0;
 
-       btrfs_inode_lock(inode, BTRFS_ILOCK_SHARED);
+       btrfs_inode_lock(BTRFS_I(inode), BTRFS_ILOCK_SHARED);
 again:
        /*
         * This is similar to what we do for direct IO writes, see the comment

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index f612c8b9d4bccfa6fa053ed6671329b74dbef24f..9b0f84c85befa82263a1d11a7924363fa27564b1 100644 (file)
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -172,27 +172,27 @@ static void __cold btrfs_print_data_csum_error(struct btrfs_inode *inode,
  *                  return -EAGAIN
  * BTRFS_ILOCK_MMAP - acquire a write lock on the i_mmap_lock
  */
-int btrfs_inode_lock(struct inode *inode, unsigned int ilock_flags)
+int btrfs_inode_lock(struct btrfs_inode *inode, unsigned int ilock_flags)
 {
        if (ilock_flags & BTRFS_ILOCK_SHARED) {
                if (ilock_flags & BTRFS_ILOCK_TRY) {
-                       if (!inode_trylock_shared(inode))
+                       if (!inode_trylock_shared(&inode->vfs_inode))
                                return -EAGAIN;
                        else
                                return 0;
                }
-               inode_lock_shared(inode);
+               inode_lock_shared(&inode->vfs_inode);
        } else {
                if (ilock_flags & BTRFS_ILOCK_TRY) {
-                       if (!inode_trylock(inode))
+                       if (!inode_trylock(&inode->vfs_inode))
                                return -EAGAIN;
                        else
                                return 0;
                }
-               inode_lock(inode);
+               inode_lock(&inode->vfs_inode);
        }
        if (ilock_flags & BTRFS_ILOCK_MMAP)
-               down_write(&BTRFS_I(inode)->i_mmap_lock);
+               down_write(&inode->i_mmap_lock);
        return 0;
 }
 
@@ -10529,7 +10529,7 @@ ssize_t btrfs_encoded_read(struct kiocb *iocb, struct iov_iter *iter,
 
        file_accessed(iocb->ki_filp);
 
-       btrfs_inode_lock(&inode->vfs_inode, BTRFS_ILOCK_SHARED);
+       btrfs_inode_lock(inode, BTRFS_ILOCK_SHARED);
 
        if (iocb->ki_pos >= inode->vfs_inode.i_size) {
                btrfs_inode_unlock(&inode->vfs_inode, BTRFS_ILOCK_SHARED);

diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index 6f9f8e8dfea681fa0bac77fb8931a98d52200ddb..a912e1cb283d8acf444e8b55805586566ee22733 100644 (file)
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -2528,7 +2528,7 @@ static noinline int btrfs_ioctl_snap_destroy(struct file *file,
                goto out_dput;
        }
 
-       btrfs_inode_lock(inode, 0);
+       btrfs_inode_lock(BTRFS_I(inode), 0);
        err = btrfs_delete_subvolume(dir, dentry);
        btrfs_inode_unlock(inode, 0);
        if (!err)

diff --git a/fs/btrfs/reflink.c b/fs/btrfs/reflink.c
index 9d728107536e8182a91bff43f4b4f8a530081ef0..c62c7fdd55d9d2fd54868341336e9e88fcf1881e 100644 (file)
--- a/fs/btrfs/reflink.c
+++ b/fs/btrfs/reflink.c
@@ -893,7 +893,7 @@ loff_t btrfs_remap_file_range(struct file *src_file, loff_t off,
                return -EINVAL;
 
        if (same_inode) {
-               btrfs_inode_lock(src_inode, BTRFS_ILOCK_MMAP);
+               btrfs_inode_lock(BTRFS_I(src_inode), BTRFS_ILOCK_MMAP);
        } else {
                lock_two_nondirectories(src_inode, dst_inode);
                btrfs_double_mmap_lock(src_inode, dst_inode);

diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 2ecca24e100168252f49e0e23b6d579da7d2f2e1..f34cb92f315145f276a80474f8d7c9fde1413945 100644 (file)
--- a/fs/btrfs/relocation.c
+++ b/fs/btrfs/relocation.c
@@ -2874,7 +2874,7 @@ static noinline_for_stack int prealloc_file_extent_cluster(
        if (ret)
                return ret;
 
-       btrfs_inode_lock(&inode->vfs_inode, 0);
+       btrfs_inode_lock(inode, 0);
        for (nr = 0; nr < cluster->nr; nr++) {
                struct extent_state *cached_state = NULL;