]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
sctp: allow setting SCTP_SACK_IMMEDIATELY by the application
authorMarcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Fri, 22 Jan 2016 20:29:49 +0000 (18:29 -0200)
committerChuck Anderson <chuck.anderson@oracle.com>
Thu, 26 May 2016 22:45:15 +0000 (15:45 -0700)
Orabug: 23330933

[ Upstream commit 27f7ed2b11d42ab6d796e96533c2076ec220affc ]

This patch extends commit b93d6471748d ("sctp: implement the sender side
for SACK-IMMEDIATELY extension") as it didn't white list
SCTP_SACK_IMMEDIATELY on sctp_msghdr_parse(), causing it to be
understood as an invalid flag and returning -EINVAL to the application.

Note that the actual handling of the flag is already there in
sctp_datamsg_from_user().

https://tools.ietf.org/html/rfc7053#section-7

Fixes: b93d6471748d ("sctp: implement the sender side for SACK-IMMEDIATELY extension")
Signed-off-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 6e13e7b0183e0b9945ff350bd5fad573c2ece83c)

Signed-off-by: Dan Duval <dan.duval@oracle.com>
net/sctp/socket.c

index 83e5f00ca2322a0772ccbaa07a3ead47b2d01613..d73385df0e6dfa7c51c308e9905f290fe74cf441 100644 (file)
@@ -6653,6 +6653,7 @@ static int sctp_msghdr_parse(const struct msghdr *msg, sctp_cmsgs_t *cmsgs)
 
                        if (cmsgs->srinfo->sinfo_flags &
                            ~(SCTP_UNORDERED | SCTP_ADDR_OVER |
+                             SCTP_SACK_IMMEDIATELY |
                              SCTP_ABORT | SCTP_EOF))
                                return -EINVAL;
                        break;
@@ -6676,6 +6677,7 @@ static int sctp_msghdr_parse(const struct msghdr *msg, sctp_cmsgs_t *cmsgs)
 
                        if (cmsgs->sinfo->snd_flags &
                            ~(SCTP_UNORDERED | SCTP_ADDR_OVER |
+                             SCTP_SACK_IMMEDIATELY |
                              SCTP_ABORT | SCTP_EOF))
                                return -EINVAL;
                        break;