]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
spi: intel: Add check devm_kasprintf() returned value
authorCharles Han <hanchunchao@inspur.com>
Fri, 30 Aug 2024 07:41:06 +0000 (15:41 +0800)
committerMark Brown <broonie@kernel.org>
Fri, 30 Aug 2024 11:28:17 +0000 (12:28 +0100)
intel_spi_populate_chip() use devm_kasprintf() to set pdata->name.
This can return a NULL pointer on failure but this returned value
is not checked.

Fixes: e58db3bcd93b ("spi: intel: Add default partition and name to the second chip")
Signed-off-by: Charles Han <hanchunchao@inspur.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Link: https://patch.msgid.link/20240830074106.8744-1-hanchunchao@inspur.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-intel.c

index 3e5dcf2b3c8a19621bbfea6bd724440ddcc7f0c1..795b7e72baead0f94a46991ed19e353ae6651abd 100644 (file)
@@ -1390,6 +1390,9 @@ static int intel_spi_populate_chip(struct intel_spi *ispi)
 
        pdata->name = devm_kasprintf(ispi->dev, GFP_KERNEL, "%s-chip1",
                                     dev_name(ispi->dev));
+       if (!pdata->name)
+               return -ENOMEM;
+
        pdata->nr_parts = 1;
        parts = devm_kcalloc(ispi->dev, pdata->nr_parts, sizeof(*parts),
                             GFP_KERNEL);