]> www.infradead.org Git - users/hch/misc.git/commitdiff
kunit: Always descend into kunit directory during build
authorThomas Weißschuh <thomas.weissschuh@linutronix.de>
Wed, 13 Aug 2025 06:28:30 +0000 (08:28 +0200)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 15 Aug 2025 17:39:46 +0000 (11:39 -0600)
For kbuild to properly clean up these build artifacts in the subdirectory,
even after CONFIG_KUNIT changed do disabled, the directory needs to be
processed always.

Pushing the special logic for hook.o into the kunit Makefile also makes the
logic easier to understand.

Link: https://lore.kernel.org/r/20250813-kunit-always-descend-v1-1-7bbd387ff13b@linutronix.de
Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Reviewed-by: David Gow <davidgow@google.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
lib/Makefile
lib/kunit/Makefile

index 392ff808c9b90210849e397356d1aa435a47bd07..15a03f4c16e2cd6c75297005e71fa2108c1f41f2 100644 (file)
@@ -109,11 +109,7 @@ test_fpu-y := test_fpu_glue.o test_fpu_impl.o
 CFLAGS_test_fpu_impl.o += $(CC_FLAGS_FPU)
 CFLAGS_REMOVE_test_fpu_impl.o += $(CC_FLAGS_NO_FPU)
 
-# Some KUnit files (hooks.o) need to be built-in even when KUnit is a module,
-# so we can't just use obj-$(CONFIG_KUNIT).
-ifdef CONFIG_KUNIT
 obj-y += kunit/
-endif
 
 ifeq ($(CONFIG_DEBUG_KOBJECT),y)
 CFLAGS_kobject.o += -DDEBUG
index 5aa51978e456ab3bb60c12071a26cf2bdcb1b508..656f1fa35abcc635e67d5b4cb1bc586b48415ac5 100644 (file)
@@ -17,7 +17,7 @@ kunit-objs +=                         debugfs.o
 endif
 
 # KUnit 'hooks' are built-in even when KUnit is built as a module.
-obj-y +=                               hooks.o
+obj-$(if $(CONFIG_KUNIT),y) +=         hooks.o
 
 obj-$(CONFIG_KUNIT_TEST) +=            kunit-test.o
 obj-$(CONFIG_KUNIT_TEST) +=            platform-test.o