]> www.infradead.org Git - users/willy/pagecache.git/commitdiff
writeback: Remove writeback_use_writepage()
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Fri, 7 Mar 2025 04:43:13 +0000 (23:43 -0500)
committerMatthew Wilcox (Oracle) <willy@infradead.org>
Mon, 17 Mar 2025 22:19:56 +0000 (18:19 -0400)
The ->writepage operation is going away.  Remove this alternative to
calling ->writepages.

Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
mm/page-writeback.c

index 18456ddd463b102dffcff3b9127b0756123604ea..3cf7ae45be58306af21574bf1cf55cdccb89e90c 100644 (file)
@@ -2621,27 +2621,6 @@ int write_cache_pages(struct address_space *mapping,
 }
 EXPORT_SYMBOL(write_cache_pages);
 
-static int writeback_use_writepage(struct address_space *mapping,
-               struct writeback_control *wbc)
-{
-       struct folio *folio = NULL;
-       struct blk_plug plug;
-       int err;
-
-       blk_start_plug(&plug);
-       while ((folio = writeback_iter(mapping, wbc, folio, &err))) {
-               err = mapping->a_ops->writepage(&folio->page, wbc);
-               if (err == AOP_WRITEPAGE_ACTIVATE) {
-                       folio_unlock(folio);
-                       err = 0;
-               }
-               mapping_set_error(mapping, err);
-       }
-       blk_finish_plug(&plug);
-
-       return err;
-}
-
 int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
 {
        int ret;
@@ -2652,14 +2631,11 @@ int do_writepages(struct address_space *mapping, struct writeback_control *wbc)
        wb = inode_to_wb_wbc(mapping->host, wbc);
        wb_bandwidth_estimate_start(wb);
        while (1) {
-               if (mapping->a_ops->writepages) {
+               if (mapping->a_ops->writepages)
                        ret = mapping->a_ops->writepages(mapping, wbc);
-               } else if (mapping->a_ops->writepage) {
-                       ret = writeback_use_writepage(mapping, wbc);
-               } else {
+               else
                        /* deal with chardevs and other special files */
                        ret = 0;
-               }
                if (ret != -ENOMEM || wbc->sync_mode != WB_SYNC_ALL)
                        break;