ext4: remove unnecessary e4b->bd_buddy_page check in ext4_mb_load_buddy_gfp

e4b->bd_buddy_page is only set if we initialize ext4_buddy successfully. So
e4b->bd_buddy_page is always NULL in error handle branch. Just remove the
dead check.

Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Link: https://lore.kernel.org/r/20230303172120.3800725-11-shikemeng@huaweicloud.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
index 17cfe6c2b582c2e08dd332512d39e2263559acba..8d3d59876a4a94fa91385c8f034efb1ba2ac447c 100644 (file)
--- a/fs/ext4/mballoc.c
+++ b/fs/ext4/mballoc.c
@@ -1555,8 +1555,7 @@ err:
                put_page(page);
        if (e4b->bd_bitmap_page)
                put_page(e4b->bd_bitmap_page);
-       if (e4b->bd_buddy_page)
-               put_page(e4b->bd_buddy_page);
+
        e4b->bd_buddy = NULL;
        e4b->bd_bitmap = NULL;
        return ret;