]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drivers: net: e1000e: use setup_timer() helper.
authorAllen Pais <allen.lkml@gmail.com>
Thu, 21 Sep 2017 17:04:52 +0000 (22:34 +0530)
committerJack Vogel <jack.vogel@oracle.com>
Mon, 8 Jan 2018 17:48:16 +0000 (09:48 -0800)
Use setup_timer function instead of initializing timer with the
    function and data fields.

Signed-off-by: Allen Pais <allen.lkml@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Orabug: 27069012
(cherry picked from commit 4a9c07ed71c2b8d755ee585264f80dd2d82a8066)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
Reviewed-by: Ethan Zhao <ethan.zhao@oracle.com>
drivers/net/ethernet/intel/e1000e/netdev.c

index 1bfda81d59ccda06c1ff14ab84d1c66fc4a5d184..d3cf06eeee7d2a1db31dec599f61f9f3aa3b791f 100644 (file)
@@ -7252,13 +7252,10 @@ static int e1000_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
                goto err_eeprom;
        }
 
-       init_timer(&adapter->watchdog_timer);
-       adapter->watchdog_timer.function = e1000_watchdog;
-       adapter->watchdog_timer.data = (unsigned long)adapter;
-
-       init_timer(&adapter->phy_info_timer);
-       adapter->phy_info_timer.function = e1000_update_phy_info;
-       adapter->phy_info_timer.data = (unsigned long)adapter;
+       setup_timer(&adapter->watchdog_timer, e1000_watchdog,
+                   (unsigned long)adapter);
+       setup_timer(&adapter->phy_info_timer, e1000_update_phy_info,
+                   (unsigned long)adapter);
 
        INIT_WORK(&adapter->reset_task, e1000_reset_task);
        INIT_WORK(&adapter->watchdog_task, e1000_watchdog_task);