]> www.infradead.org Git - linux.git/commitdiff
drm/amd/display: Hardware cursor changes color when switched to software cursor
authorNevenko Stupar <Nevenko.Stupar@amd.com>
Thu, 15 Aug 2024 22:45:18 +0000 (18:45 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 21 Aug 2024 02:14:13 +0000 (22:14 -0400)
[Why & How]
DCN4 Cursor has separate degamma block and should always
do Cursor degamma for Cursor color modes.

Reviewed-by: Chris Park <chris.park@amd.com>
Signed-off-by: Nevenko Stupar <Nevenko.Stupar@amd.com>
Signed-off-by: Roman Li <roman.li@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dpp/dcn401/dcn401_dpp_cm.c

index 92b34fe47f7400a2615a4c8cb7107309a490d172..3b6ca7974e188df5ed8bd7579fd416acd12e950e 100644 (file)
@@ -120,11 +120,10 @@ void dpp401_set_cursor_attributes(
        enum dc_cursor_color_format color_format = cursor_attributes->color_format;
        int cur_rom_en = 0;
 
+       // DCN4 should always do Cursor degamma for Cursor Color modes
        if (color_format == CURSOR_MODE_COLOR_PRE_MULTIPLIED_ALPHA ||
                color_format == CURSOR_MODE_COLOR_UN_PRE_MULTIPLIED_ALPHA) {
-               if (cursor_attributes->attribute_flags.bits.ENABLE_CURSOR_DEGAMMA) {
-                       cur_rom_en = 1;
-               }
+               cur_rom_en = 1;
        }
 
        REG_UPDATE_3(CURSOR0_CONTROL,