]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
kvm: fix previous commit for 32-bit builds
authorPaolo Bonzini <pbonzini@redhat.com>
Wed, 9 Jun 2021 05:49:13 +0000 (01:49 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jun 2021 09:55:01 +0000 (11:55 +0200)
commit 4422829e8053068e0225e4d0ef42dc41ea7c9ef5 upstream.

array_index_nospec does not work for uint64_t on 32-bit builds.
However, the size of a memory slot must be less than 20 bits wide
on those system, since the memory slot must fit in the user
address space.  So just store it in an unsigned long.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/kvm_host.h

index eb758bbdb4f6562b9506e4023bf4bddf73cc84ff..8dd4ebb58e9733bdbd6f3af8e8986b70f8ee06c2 100644 (file)
@@ -1023,8 +1023,8 @@ __gfn_to_hva_memslot(struct kvm_memory_slot *slot, gfn_t gfn)
         * table walks, do not let the processor speculate loads outside
         * the guest's registered memslots.
         */
-       unsigned long offset = array_index_nospec(gfn - slot->base_gfn,
-                                                 slot->npages);
+       unsigned long offset = gfn - slot->base_gfn;
+       offset = array_index_nospec(offset, slot->npages);
        return slot->userspace_addr + offset * PAGE_SIZE;
 }