]> www.infradead.org Git - nvme.git/commitdiff
block/bdev: use helper for max block size check
authorLuis Chamberlain <mcgrof@kernel.org>
Wed, 18 Dec 2024 02:02:11 +0000 (18:02 -0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 18 Dec 2024 14:22:30 +0000 (07:22 -0700)
We already have a helper for checking the limits on the block size
both low and high, just use that.

No functional changes.

Reviewed-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20241218020212.3657139-2-mcgrof@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/bdev.c

index 738e3c8457e7f430332e6852e2b1baa2883af326..9d73a8fbf7f99712e4aead293e92734d25477abf 100644 (file)
@@ -155,8 +155,7 @@ int set_blocksize(struct file *file, int size)
        struct inode *inode = file->f_mapping->host;
        struct block_device *bdev = I_BDEV(inode);
 
-       /* Size must be a power of two, and between 512 and PAGE_SIZE */
-       if (size > PAGE_SIZE || size < 512 || !is_power_of_2(size))
+       if (blk_validate_block_size(size))
                return -EINVAL;
 
        /* Size cannot be smaller than the size supported by the device */