]> www.infradead.org Git - users/hch/misc.git/commitdiff
phy: cdns-dphy: Remove leftover code
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Wed, 23 Jul 2025 10:01:29 +0000 (13:01 +0300)
committerVinod Koul <vkoul@kernel.org>
Wed, 13 Aug 2025 06:49:24 +0000 (12:19 +0530)
The code in cdns-dphy has probably been part of a DSI driver in the
past. Remove DSI defines and variables which are not used or do not
actually do anything. Also rename cdns_dsi_get_dphy_pll_cfg() to
cdns_dphy_get_pll_cfg(), i.e. drop the "dsi", as it's not relevant here.

Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
Tested-by: Parth Pancholi <parth.pancholi@toradex.com>
Acked-by: Vinod Koul <vkoul@kernel.org>
Tested-by: Jayesh Choudhary <j-choudhary@ti.com>
Reviewed-by: Devarsh Thakkar <devarsht@ti.com>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://lore.kernel.org/r/20250723-cdns-dphy-hs-clk-rate-fix-v1-2-d4539d44cbe7@ideasonboard.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/cadence/cdns-dphy.c

index f79ec4fab40936fbb568a05bd077efe5c45baaca..33a42e72362ec11b982484e0a2d20b95deadb7d1 100644 (file)
 #define DPHY_PSM_CFG_FROM_REG          BIT(0)
 #define DPHY_PSM_CLK_DIV(x)            ((x) << 1)
 
-#define DSI_HBP_FRAME_OVERHEAD         12
-#define DSI_HSA_FRAME_OVERHEAD         14
-#define DSI_HFP_FRAME_OVERHEAD         6
-#define DSI_HSS_VSS_VSE_FRAME_OVERHEAD 4
-#define DSI_BLANKING_FRAME_OVERHEAD    6
-#define DSI_NULL_FRAME_OVERHEAD                6
-#define DSI_EOT_PKT_SIZE               4
-
 #define DPHY_TX_J721E_WIZ_PLL_CTRL     0xF04
 #define DPHY_TX_J721E_WIZ_STATUS       0xF08
 #define DPHY_TX_J721E_WIZ_RST_CTRL     0xF0C
@@ -117,10 +109,9 @@ static const unsigned int tx_bands[] = {
        870, 950, 1000, 1200, 1400, 1600, 1800, 2000, 2200, 2500
 };
 
-static int cdns_dsi_get_dphy_pll_cfg(struct cdns_dphy *dphy,
-                                    struct cdns_dphy_cfg *cfg,
-                                    struct phy_configure_opts_mipi_dphy *opts,
-                                    unsigned int *dsi_hfp_ext)
+static int cdns_dphy_get_pll_cfg(struct cdns_dphy *dphy,
+                                struct cdns_dphy_cfg *cfg,
+                                struct phy_configure_opts_mipi_dphy *opts)
 {
        unsigned long pll_ref_hz = clk_get_rate(dphy->pll_ref_clk);
        u64 dlane_bps;
@@ -289,15 +280,13 @@ static int cdns_dphy_config_from_opts(struct phy *phy,
                                      struct cdns_dphy_cfg *cfg)
 {
        struct cdns_dphy *dphy = phy_get_drvdata(phy);
-       unsigned int dsi_hfp_ext = 0;
        int ret;
 
        ret = phy_mipi_dphy_config_validate(opts);
        if (ret)
                return ret;
 
-       ret = cdns_dsi_get_dphy_pll_cfg(dphy, cfg,
-                                       opts, &dsi_hfp_ext);
+       ret = cdns_dphy_get_pll_cfg(dphy, cfg, opts);
        if (ret)
                return ret;