net: devlink: move reload fail indication to devlink core and expose to user

Currently the fact that devlink reload failed is stored in drivers.
Move this flag into devlink core. Also, expose it to the user.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index c71a1d9ea17b7f5049c799b157474787d156843e..3fa96076e8a54e34d60e15e313dd125b76e7ebf4 100644 (file)
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -80,7 +80,6 @@ struct mlxsw_core {
        struct mlxsw_thermal *thermal;
        struct mlxsw_core_port *ports;
        unsigned int max_ports;
-       bool reload_fail;
        bool fw_flash_in_progress;
        unsigned long driver_priv[0];
        /* driver_priv has to be always the last item */
@@ -1002,15 +1001,11 @@ mlxsw_devlink_core_bus_device_reload_up(struct devlink *devlink,
                                        struct netlink_ext_ack *extack)
 {
        struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
-       int err;
-
-       err = mlxsw_core_bus_device_register(mlxsw_core->bus_info,
-                                            mlxsw_core->bus,
-                                            mlxsw_core->bus_priv, true,
-                                            devlink);
-       mlxsw_core->reload_fail = !!err;
 
-       return err;
+       return mlxsw_core_bus_device_register(mlxsw_core->bus_info,
+                                             mlxsw_core->bus,
+                                             mlxsw_core->bus_priv, true,
+                                             devlink);
 }
 
 static int mlxsw_devlink_flash_update(struct devlink *devlink,
@@ -1254,7 +1249,7 @@ void mlxsw_core_bus_device_unregister(struct mlxsw_core *mlxsw_core,
 {
        struct devlink *devlink = priv_to_devlink(mlxsw_core);
 
-       if (mlxsw_core->reload_fail) {
+       if (devlink_is_reload_failed(devlink)) {
                if (!reload)
                        /* Only the parts that were not de-initialized in the
                         * failed reload attempt need to be de-initialized.

diff --git a/include/net/devlink.h b/include/net/devlink.h
index ab8d56d12ffdabc3091a980baf90f311e4aa2ba2..23e4b65ec9df4b0fb33c00b943d3253bcaeab86c 100644 (file)
--- a/include/net/devlink.h
+++ b/include/net/devlink.h
@@ -38,6 +38,7 @@ struct devlink {
        struct device *dev;
        possible_net_t _net;
        struct mutex lock;
+       bool reload_failed;
        char priv[0] __aligned(NETDEV_ALIGN);
 };
 
@@ -945,6 +946,8 @@ void
 devlink_health_reporter_state_update(struct devlink_health_reporter *reporter,
                                     enum devlink_health_reporter_state state);
 
+bool devlink_is_reload_failed(const struct devlink *devlink);
+
 void devlink_flash_update_begin_notify(struct devlink *devlink);
 void devlink_flash_update_end_notify(struct devlink *devlink);
 void devlink_flash_update_status_notify(struct devlink *devlink,

diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 8da5365850cddd58ec16905fbdfbe4de059f3ea5..580b7a2e40e184b8b560c0851c4a104b69cd0f8b 100644 (file)
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -419,6 +419,8 @@ enum devlink_attr {
        DEVLINK_ATTR_TRAP_METADATA,                     /* nested */
        DEVLINK_ATTR_TRAP_GROUP_NAME,                   /* string */
 
+       DEVLINK_ATTR_RELOAD_FAILED,                     /* u8 0 or 1 */
+
        /* add new attributes above here, update the policy in devlink.c */
 
        __DEVLINK_ATTR_MAX,

diff --git a/net/core/devlink.c b/net/core/devlink.c
index 9e522639693d87576ecc5685b28f3d2560b4a0e6..e48680efe54a92bb19c5d7902fb25c16a9ce1d8a 100644 (file)
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -471,6 +471,8 @@ static int devlink_nl_fill(struct sk_buff *msg, struct devlink *devlink,
 
        if (devlink_nl_put_handle(msg, devlink))
                goto nla_put_failure;
+       if (nla_put_u8(msg, DEVLINK_ATTR_RELOAD_FAILED, devlink->reload_failed))
+               goto nla_put_failure;
 
        genlmsg_end(msg, hdr);
        return 0;
@@ -2677,6 +2679,21 @@ static bool devlink_reload_supported(struct devlink *devlink)
        return devlink->ops->reload_down && devlink->ops->reload_up;
 }
 
+static void devlink_reload_failed_set(struct devlink *devlink,
+                                     bool reload_failed)
+{
+       if (devlink->reload_failed == reload_failed)
+               return;
+       devlink->reload_failed = reload_failed;
+       devlink_notify(devlink, DEVLINK_CMD_NEW);
+}
+
+bool devlink_is_reload_failed(const struct devlink *devlink)
+{
+       return devlink->reload_failed;
+}
+EXPORT_SYMBOL_GPL(devlink_is_reload_failed);
+
 static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info)
 {
        struct devlink *devlink = info->user_ptr[0];
@@ -2693,7 +2710,9 @@ static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info)
        err = devlink->ops->reload_down(devlink, info->extack);
        if (err)
                return err;
-       return devlink->ops->reload_up(devlink, info->extack);
+       err = devlink->ops->reload_up(devlink, info->extack);
+       devlink_reload_failed_set(devlink, !!err);
+       return err;
 }
 
 static int devlink_nl_flash_update_fill(struct sk_buff *msg,