]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
scsi: qla2xxx: Fix MPI reset needed message
authorArun Easi <aeasi@marvell.com>
Tue, 29 Sep 2020 10:21:48 +0000 (03:21 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 10:51:35 +0000 (11:51 +0100)
commit 7a6cdbd5e87515ebf6231b762ad903c7cff87b9c upstream.

When printing the message:

  "MPI Heartbeat stop. MPI reset is not needed.."

..the wrong register was checked leading to always printing that MPI reset
is not needed, even when it is needed. Fix the MPI reset message.

Link: https://lore.kernel.org/r/20200929102152.32278-4-njavali@marvell.com
Fixes: cbb01c2f2f63 ("scsi: qla2xxx: Fix MPI failure AEN (8200) handling")
Cc: stable@vger.kernel.org
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
Signed-off-by: Arun Easi <aeasi@marvell.com>
Signed-off-by: Nilesh Javali <njavali@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/qla2xxx/qla_isr.c

index 25e0a1684763251da1cae29a66279a89aaea3d8d..96db78c8820097873e1ee313c80fddcb757837ee 100644 (file)
@@ -767,7 +767,7 @@ qla27xx_handle_8200_aen(scsi_qla_host_t *vha, uint16_t *mb)
        ql_log(ql_log_warn, vha, 0x02f0,
               "MPI Heartbeat stop. MPI reset is%s needed. "
               "MB0[%xh] MB1[%xh] MB2[%xh] MB3[%xh]\n",
-              mb[0] & BIT_8 ? "" : " not",
+              mb[1] & BIT_8 ? "" : " not",
               mb[0], mb[1], mb[2], mb[3]);
 
        if ((mb[1] & BIT_8) == 0)