]> www.infradead.org Git - users/hch/xfs.git/commitdiff
xfs: do not check NEEDSREPAIR if ro,norecovery mount.
authorLukas Herbolt <lukas@herbolt.com>
Mon, 3 Feb 2025 08:55:13 +0000 (09:55 +0100)
committerCarlos Maiolino <cem@kernel.org>
Mon, 10 Feb 2025 09:18:39 +0000 (10:18 +0100)
If there is corrutpion on the filesystem andxfs_repair
fails to repair it. The last resort of getting the data
is to use norecovery,ro mount. But if the NEEDSREPAIR is
set the filesystem cannot be mounted. The flag must be
cleared out manually using xfs_db, to get access to what
left over of the corrupted fs.

Signed-off-by: Lukas Herbolt <lukas@herbolt.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Carlos Maiolino <cem@kernel.org>
fs/xfs/xfs_super.c

index d92d7a07ea89b8781494ed35e87635602266b4a1..0055066fb1d98b51969fbafd971c04e20fce48fe 100644 (file)
@@ -1661,8 +1661,12 @@ xfs_fs_fill_super(
 #endif
        }
 
-       /* Filesystem claims it needs repair, so refuse the mount. */
-       if (xfs_has_needsrepair(mp)) {
+       /*
+        * Filesystem claims it needs repair, so refuse the mount unless
+        * norecovery is also specified, in which case the filesystem can
+        * be mounted with no risk of further damage.
+        */
+       if (xfs_has_needsrepair(mp) && !xfs_has_norecovery(mp)) {
                xfs_warn(mp, "Filesystem needs repair.  Please run xfs_repair.");
                error = -EFSCORRUPTED;
                goto out_free_sb;