]> www.infradead.org Git - users/hch/misc.git/commitdiff
ASoC: renesas: msiof: tidyup DMAC stop timing
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 25 Sep 2025 05:17:27 +0000 (05:17 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 25 Sep 2025 16:43:27 +0000 (17:43 +0100)
Current DMAC is stopped before HW stop, but it might be cause of
sync error. Stop HW first.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Tested-by: Yusuke Goda <yusuke.goda.sx@renesas.com>
Link: https://patch.msgid.link/878qi3yuu0.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/renesas/rcar/msiof.c

index d501ad9d71413bb8ce5e3de03765974336809484..5b59d4bcd67eb820e8244593a931963ae48c18ef 100644 (file)
@@ -238,9 +238,6 @@ static int msiof_hw_stop(struct snd_soc_component *component,
                val = SIIER_RDREQE | SIIER_RDMAE | SISTR_ERR_RX;
        msiof_update(priv, SIIER, val, 0);
 
-       /* Stop DMAC */
-       snd_dmaengine_pcm_trigger(substream, cmd);
-
        /* SICTR */
        if (is_play)
                val = SICTR_TXE;
@@ -248,6 +245,9 @@ static int msiof_hw_stop(struct snd_soc_component *component,
                val = SICTR_RXE;
        msiof_update_and_wait(priv, SICTR, val, 0, 0);
 
+       /* Stop DMAC */
+       snd_dmaengine_pcm_trigger(substream, cmd);
+
        /* indicate error status if exist */
        if (priv->err_syc[substream->stream] ||
            priv->err_ovf[substream->stream] ||