]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: stm32: dcmipp: use v4l2_subdev_is_streaming
authorAlain Volmat <alain.volmat@foss.st.com>
Thu, 12 Dec 2024 09:17:28 +0000 (10:17 +0100)
committerHans Verkuil <hverkuil@xs4all.nl>
Thu, 12 Dec 2024 12:22:26 +0000 (13:22 +0100)
Rely on v4l2_subdev_is_streaming in order to know if the subdev
is streaming or not instead of relying on a local variable.

Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-byteproc.c
drivers/media/platform/st/stm32/stm32-dcmipp/dcmipp-parallel.c

index 5a361ad6b0234c5de03c12b0b7b9d428eae63c06..50500112eab9a7b10a0c5e29773e31ded1a66628 100644 (file)
@@ -78,7 +78,6 @@ struct dcmipp_byteproc_device {
        struct v4l2_subdev sd;
        struct device *dev;
        void __iomem *regs;
-       bool streaming;
 };
 
 static const struct v4l2_mbus_framefmt fmt_default = {
@@ -239,11 +238,10 @@ static int dcmipp_byteproc_set_fmt(struct v4l2_subdev *sd,
                                   struct v4l2_subdev_state *sd_state,
                                   struct v4l2_subdev_format *fmt)
 {
-       struct dcmipp_byteproc_device *byteproc = v4l2_get_subdevdata(sd);
        struct v4l2_mbus_framefmt *mf;
        struct v4l2_rect *crop, *compose;
 
-       if (byteproc->streaming)
+       if (v4l2_subdev_is_streaming(sd))
                return -EBUSY;
 
        mf = v4l2_subdev_state_get_format(sd_state, fmt->pad);
@@ -495,8 +493,6 @@ static int dcmipp_byteproc_s_stream(struct v4l2_subdev *sd, int enable)
                }
        }
 
-       byteproc->streaming = enable;
-
        return 0;
 }
 
index 62c5c3331cfecdf5fcf0a5d20b4051b1b024968e..05e8897ae37a4b6c8e16c066e83ff5b1d1e07635 100644 (file)
@@ -129,7 +129,6 @@ struct dcmipp_par_device {
        struct v4l2_subdev sd;
        struct device *dev;
        void __iomem *regs;
-       bool streaming;
 };
 
 static const struct v4l2_mbus_framefmt fmt_default = {
@@ -230,7 +229,7 @@ static int dcmipp_par_set_fmt(struct v4l2_subdev *sd,
        struct dcmipp_par_device *par = v4l2_get_subdevdata(sd);
        struct v4l2_mbus_framefmt *mf;
 
-       if (par->streaming)
+       if (v4l2_subdev_is_streaming(sd))
                return -EBUSY;
 
        mf = v4l2_subdev_state_get_format(sd_state, fmt->pad);
@@ -370,8 +369,6 @@ static int dcmipp_par_s_stream(struct v4l2_subdev *sd, int enable)
                reg_clear(par, DCMIPP_PRCR, DCMIPP_PRCR_ENABLE);
        }
 
-       par->streaming = enable;
-
        return ret;
 }