]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
iwlwifi: mvm: rfi: use kmemdup() to replace kzalloc + memcpy
authorBixuan Cui <cuibixuan@linux.alibaba.com>
Wed, 27 Oct 2021 06:58:40 +0000 (14:58 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 10 Apr 2024 14:19:35 +0000 (16:19 +0200)
[ Upstream commit 08186e2501eec554cde8bae53b1d1de4d54abdf4 ]

Fix memdup.cocci warning:
./drivers/net/wireless/intel/iwlwifi/mvm/rfi.c:110:8-15: WARNING
opportunity for kmemdup

Signed-off-by: Bixuan Cui <cuibixuan@linux.alibaba.com>
Link: https://lore.kernel.org/r/1635317920-84725-1-git-send-email-cuibixuan@linux.alibaba.com
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Stable-dep-of: 06a093807eb7 ("wifi: iwlwifi: mvm: rfi: fix potential response leaks")
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/intel/iwlwifi/mvm/rfi.c

index 44344216a1a9093fb8df0f51fdf8a1f3a41baef7..1954b4cdb90b47bea159735436fbf4f72dd8a3e6 100644 (file)
@@ -107,12 +107,10 @@ struct iwl_rfi_freq_table_resp_cmd *iwl_rfi_get_freq_table(struct iwl_mvm *mvm)
        if (WARN_ON_ONCE(iwl_rx_packet_payload_len(cmd.resp_pkt) != resp_size))
                return ERR_PTR(-EIO);
 
-       resp = kzalloc(resp_size, GFP_KERNEL);
+       resp = kmemdup(cmd.resp_pkt->data, resp_size, GFP_KERNEL);
        if (!resp)
                return ERR_PTR(-ENOMEM);
 
-       memcpy(resp, cmd.resp_pkt->data, resp_size);
-
        iwl_free_resp(&cmd);
        return resp;
 }