]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
fbdev/xen-fbfront: Use struct fb_info.screen_buffer
authorThomas Zimmermann <tzimmermann@suse.de>
Fri, 28 Apr 2023 12:24:46 +0000 (14:24 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Mon, 8 May 2023 13:28:33 +0000 (15:28 +0200)
Use info->screen_buffer when reading and writing framebuffers in
system memory. It's the correct pointer for this address space.

The struct fb_info has a union to store the framebuffer memory. This can
either be info->screen_base if the framebuffer is stored in I/O memory,
or info->screen_buffer if the framebuffer is stored in system memory.

As the driver operates on the latter address space, it is wrong to use
.screen_base and .screen_buffer must be used instead.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230428122452.4856-14-tzimmermann@suse.de
drivers/video/fbdev/xen-fbfront.c

index d7f3e6281ce48051b74b97a047c4fabda6a322f1..9b2a786621a63b07c76d00397f053cd67eb55db4 100644 (file)
@@ -429,7 +429,7 @@ static int xenfb_probe(struct xenbus_device *dev,
        fb_info->pseudo_palette = fb_info->par;
        fb_info->par = info;
 
-       fb_info->screen_base = info->fb;
+       fb_info->screen_buffer = info->fb;
 
        fb_info->fbops = &xenfb_fb_ops;
        fb_info->var.xres_virtual = fb_info->var.xres = video[KPARAM_WIDTH];