serial: 8250: of: Correct of_platform_serial_setup() error handling

[ Upstream commit b29330d829042512fabb2bfa3bbfa32df1115594 ]

Don't dispose IRQ mapping before it has been created.

Fixes: aa9594740 ("serial: 8250_of: Add IO space support")
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
index bfb37f0be22f2e5e732c1b18153d45a137b7ff13..863e86b9a4240589c3c96e12e21c0b6bc7cdb2ad 100644 (file)
--- a/drivers/tty/serial/8250/8250_of.c
+++ b/drivers/tty/serial/8250/8250_of.c
@@ -124,7 +124,7 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
                                dev_warn(&ofdev->dev, "unsupported reg-io-width (%d)\n",
                                         prop);
                                ret = -EINVAL;
-                               goto err_dispose;
+                               goto err_unprepare;
                        }
                }
                port->flags |= UPF_IOREMAP;