]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
watch_queue: Make comment about setting ->defunct more accurate
authorDavid Howells <dhowells@redhat.com>
Fri, 11 Mar 2022 13:24:47 +0000 (13:24 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Mar 2022 13:16:02 +0000 (14:16 +0100)
commit 4edc0760412b0c4ecefc7e02cb855b310b122825 upstream.

watch_queue_clear() has a comment stating that setting ->defunct to true
preventing new additions as well as preventing notifications.  Whilst
the latter is true, the first bit is superfluous since at the time this
function is called, the pipe cannot be accessed to add new event
sources.

Remove the "new additions" bit from the comment.

Fixes: c73be61cede5 ("pipe: Add general notification queue support")
Reported-by: Jann Horn <jannh@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/watch_queue.c

index a904f68c19aa04b4475850592705051a606d2947..65bd65fec23df051b6e6f5a040bb7863584ca151 100644 (file)
@@ -569,7 +569,7 @@ void watch_queue_clear(struct watch_queue *wqueue)
        rcu_read_lock();
        spin_lock_bh(&wqueue->lock);
 
-       /* Prevent new additions and prevent notifications from happening */
+       /* Prevent new notifications from being stored. */
        wqueue->defunct = true;
 
        while (!hlist_empty(&wqueue->watches)) {