]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
cpufreq: brcmstb-avs-cpufreq: Fix resource leaks in ->remove()
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 17 Jan 2021 14:26:44 +0000 (15:26 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Mar 2021 17:22:38 +0000 (18:22 +0100)
[ Upstream commit 3657f729b6fb5f2c0bf693742de2dcd49c572aa1 ]

If 'cpufreq_unregister_driver()' fails, just WARN and continue, so that
other resources are freed.

Fixes: de322e085995 ("cpufreq: brcmstb-avs-cpufreq: AVS CPUfreq driver for Broadcom STB SoCs")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
[ Viresh: Updated Subject ]
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/cpufreq/brcmstb-avs-cpufreq.c

index 39c462711eae04ea23da4481ed9d5f376c86c783..815dd7c33e469dee46d1f843b643ad86c2177a8d 100644 (file)
@@ -1033,8 +1033,7 @@ static int brcm_avs_cpufreq_remove(struct platform_device *pdev)
        int ret;
 
        ret = cpufreq_unregister_driver(&brcm_avs_driver);
-       if (ret)
-               return ret;
+       WARN_ON(ret);
 
        brcm_avs_cpufreq_debug_exit(pdev);