platform/x86/intel-uncore-freq: Add efficiency latency control to sysfs interface

Add the TPMI efficiency latency control fields to the sysfs interface.
The sysfs files are mapped to the TPMI uncore driver via the registered
uncore_read and uncore_write driver callbacks. These fields are not
populated on older non TPMI hardware.

Signed-off-by: Tero Kristo <tero.kristo@linux.intel.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Link: https://lore.kernel.org/r/20240828153657.1296410-4-tero.kristo@linux.intel.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
index 4e880585cbe4d0c552a4f1854348c903d6f6b0f6..e22b683a7a434c7eddfe608d092a8450f5322689 100644 (file)
--- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
+++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.c
@@ -60,11 +60,16 @@ static ssize_t show_attr(struct uncore_data *data, char *buf, enum uncore_index
 static ssize_t store_attr(struct uncore_data *data, const char *buf, ssize_t count,
                          enum uncore_index index)
 {
-       unsigned int input;
+       unsigned int input = 0;
        int ret;
 
-       if (kstrtouint(buf, 10, &input))
-               return -EINVAL;
+       if (index == UNCORE_INDEX_EFF_LAT_CTRL_HIGH_THRESHOLD_ENABLE) {
+               if (kstrtobool(buf, (bool *)&input))
+                       return -EINVAL;
+       } else {
+               if (kstrtouint(buf, 10, &input))
+                       return -EINVAL;
+       }
 
        mutex_lock(&uncore_lock);
        ret = uncore_write(data, input, index);
@@ -103,6 +108,18 @@ show_uncore_attr(max_freq_khz, UNCORE_INDEX_MAX_FREQ);
 
 show_uncore_attr(current_freq_khz, UNCORE_INDEX_CURRENT_FREQ);
 
+store_uncore_attr(elc_low_threshold_percent, UNCORE_INDEX_EFF_LAT_CTRL_LOW_THRESHOLD);
+store_uncore_attr(elc_high_threshold_percent, UNCORE_INDEX_EFF_LAT_CTRL_HIGH_THRESHOLD);
+store_uncore_attr(elc_high_threshold_enable,
+                 UNCORE_INDEX_EFF_LAT_CTRL_HIGH_THRESHOLD_ENABLE);
+store_uncore_attr(elc_floor_freq_khz, UNCORE_INDEX_EFF_LAT_CTRL_FREQ);
+
+show_uncore_attr(elc_low_threshold_percent, UNCORE_INDEX_EFF_LAT_CTRL_LOW_THRESHOLD);
+show_uncore_attr(elc_high_threshold_percent, UNCORE_INDEX_EFF_LAT_CTRL_HIGH_THRESHOLD);
+show_uncore_attr(elc_high_threshold_enable,
+                UNCORE_INDEX_EFF_LAT_CTRL_HIGH_THRESHOLD_ENABLE);
+show_uncore_attr(elc_floor_freq_khz, UNCORE_INDEX_EFF_LAT_CTRL_FREQ);
+
 #define show_uncore_data(member_name)                                  \
        static ssize_t show_##member_name(struct kobject *kobj, \
                                           struct kobj_attribute *attr, char *buf)\
@@ -146,7 +163,8 @@ show_uncore_data(initial_max_freq_khz);
 
 static int create_attr_group(struct uncore_data *data, char *name)
 {
-       int ret, freq, index = 0;
+       int ret, index = 0;
+       unsigned int val;
 
        init_attribute_rw(max_freq_khz);
        init_attribute_rw(min_freq_khz);
@@ -168,10 +186,24 @@ static int create_attr_group(struct uncore_data *data, char *name)
        data->uncore_attrs[index++] = &data->initial_min_freq_khz_kobj_attr.attr;
        data->uncore_attrs[index++] = &data->initial_max_freq_khz_kobj_attr.attr;
 
-       ret = uncore_read(data, &freq, UNCORE_INDEX_CURRENT_FREQ);
+       ret = uncore_read(data, &val, UNCORE_INDEX_CURRENT_FREQ);
        if (!ret)
                data->uncore_attrs[index++] = &data->current_freq_khz_kobj_attr.attr;
 
+       ret = uncore_read(data, &val, UNCORE_INDEX_EFF_LAT_CTRL_LOW_THRESHOLD);
+       if (!ret) {
+               init_attribute_rw(elc_low_threshold_percent);
+               init_attribute_rw(elc_high_threshold_percent);
+               init_attribute_rw(elc_high_threshold_enable);
+               init_attribute_rw(elc_floor_freq_khz);
+
+               data->uncore_attrs[index++] = &data->elc_low_threshold_percent_kobj_attr.attr;
+               data->uncore_attrs[index++] = &data->elc_high_threshold_percent_kobj_attr.attr;
+               data->uncore_attrs[index++] =
+                       &data->elc_high_threshold_enable_kobj_attr.attr;
+               data->uncore_attrs[index++] = &data->elc_floor_freq_khz_kobj_attr.attr;
+       }
+
        data->uncore_attrs[index] = NULL;
 
        data->uncore_attr_group.name = name;

diff --git a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h
index b5c7311bfa05845ff305362350a06afd0e4a8944..26c854cd5d97fd74c9ca2be7716006c719399d50 100644 (file)
--- a/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h
+++ b/drivers/platform/x86/intel/uncore-frequency/uncore-frequency-common.h
@@ -34,6 +34,13 @@
  * @domain_id_kobj_attr: Storage for kobject attribute domain_id
  * @fabric_cluster_id_kobj_attr: Storage for kobject attribute fabric_cluster_id
  * @package_id_kobj_attr: Storage for kobject attribute package_id
+ * @elc_low_threshold_percent_kobj_attr:
+               Storage for kobject attribute elc_low_threshold_percent
+ * @elc_high_threshold_percent_kobj_attr:
+               Storage for kobject attribute elc_high_threshold_percent
+ * @elc_high_threshold_enable_kobj_attr:
+               Storage for kobject attribute elc_high_threshold_enable
+ * @elc_floor_freq_khz_kobj_attr: Storage for kobject attribute elc_floor_freq_khz
  * @uncore_attrs:      Attribute storage for group creation
  *
  * This structure is used to encapsulate all data related to uncore sysfs
@@ -61,7 +68,11 @@ struct uncore_data {
        struct kobj_attribute domain_id_kobj_attr;
        struct kobj_attribute fabric_cluster_id_kobj_attr;
        struct kobj_attribute package_id_kobj_attr;
-       struct attribute *uncore_attrs[9];
+       struct kobj_attribute elc_low_threshold_percent_kobj_attr;
+       struct kobj_attribute elc_high_threshold_percent_kobj_attr;
+       struct kobj_attribute elc_high_threshold_enable_kobj_attr;
+       struct kobj_attribute elc_floor_freq_khz_kobj_attr;
+       struct attribute *uncore_attrs[13];
 };
 
 #define UNCORE_DOMAIN_ID_INVALID       -1