]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: imu: inv_icm42600: delete unneeded update watermark call
authorJean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Mon, 27 May 2024 21:00:08 +0000 (21:00 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sun, 2 Jun 2024 12:16:02 +0000 (13:16 +0100)
Update watermark will be done inside the hwfifo_set_watermark callback
just after the update_scan_mode. It is useless to do it here.

Fixes: 7f85e42a6c54 ("iio: imu: inv_icm42600: add buffer support in iio devices")
Cc: stable@vger.kernel.org
Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com>
Link: https://lore.kernel.org/r/20240527210008.612932-1-inv.git-commit@tdk.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c
drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c

index 83d8504ebfff43d8a11fc4d0636754e635361cbd..4b25666936146a7653c46fe0fc3af494ad0bb4c5 100644 (file)
@@ -130,10 +130,6 @@ static int inv_icm42600_accel_update_scan_mode(struct iio_dev *indio_dev,
        /* update data FIFO write */
        inv_sensors_timestamp_apply_odr(ts, 0, 0, 0);
        ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
-       if (ret)
-               goto out_unlock;
-
-       ret = inv_icm42600_buffer_update_watermark(st);
 
 out_unlock:
        mutex_unlock(&st->lock);
index e6f8de80128c4f8afeef4e1e2205dcfa880caa6b..938af5b640b00f58d2b8185f752c4755edfb0d25 100644 (file)
@@ -130,10 +130,6 @@ static int inv_icm42600_gyro_update_scan_mode(struct iio_dev *indio_dev,
        /* update data FIFO write */
        inv_sensors_timestamp_apply_odr(ts, 0, 0, 0);
        ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
-       if (ret)
-               goto out_unlock;
-
-       ret = inv_icm42600_buffer_update_watermark(st);
 
 out_unlock:
        mutex_unlock(&st->lock);